Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expander Zones Are Reported in Messages #51

Closed
krkeegan opened this issue Jun 25, 2020 · 1 comment
Closed

Expander Zones Are Reported in Messages #51

krkeegan opened this issue Jun 25, 2020 · 1 comment

Comments

@krkeegan
Copy link
Contributor

krkeegan commented Jun 25, 2020

zonetracking.py contains this note:

                # NOTE: Expander zone faults are handled differently than
                #       regular messages.  We don't include them in
                #       self._zones_faulted because they are not reported
                #       by the panel in it's rolling list of faults.

At least on my panel (Vista 20SE) the expander zones are still reported in the rolling messages. They are also reported as ready or faulted using the !EXP messages. Because they appear in the rolling message list, _clear_zones ends up placing them in the _zones_faulted array anyways.

The only concern this causes, is that any error in _clear_zones such as #50 will affect expander zones when it doesn't need to.

@f34rdotcom
Copy link
Contributor

Will merge into dev once I sort this serial issue out. I expect it wont take long for some feedback on the serial patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants