Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify module using vue-gtag #23

Open
ricardogobbosouza opened this issue Jan 6, 2020 · 3 comments
Open

Simplify module using vue-gtag #23

ricardogobbosouza opened this issue Jan 6, 2020 · 3 comments

Comments

@ricardogobbosouza
Copy link
Member

ricardogobbosouza commented Jan 6, 2020 •
edited
Loading

Hi @dohomi
Could we simplify this module using vue-gtag?
@dohomi
Copy link
Contributor

dohomi commented Jan 7, 2020

Its such a small package, why would you like to make a 3rd party dependency?

@ricardogobbosouza
Copy link
Member Author

ricardogobbosouza commented Jan 7, 2020 •
edited
Loading

@dohomi this plugin is very complete and has a good documentation of your api.
Not to mention some options that we need to do manually here like #20 and with this plugin simply this.$gtag.optIn() to enable and this.$gtag.optOut() to disable.
In short, it would add a lot to this module and practically solve all issues opened.

@dohomi
Copy link
Contributor

dohomi commented Jan 7, 2020

Feel free to start a PR I just won't have the time right now to look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dohomi @ricardogobbosouza