Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Upgrade gtest/gmock to 1.13 #347

Closed
2 tasks done
mdemoret-nv opened this issue Jul 6, 2023 · 1 comment
Closed
2 tasks done

[FEA]: Upgrade gtest/gmock to 1.13 #347

mdemoret-nv opened this issue Jul 6, 2023 · 1 comment
Assignees
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Change

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

Due to the changes in this PR, gtest/gmock are now runtime dependencies of libcudf which means our version needs to match their requirements.

Describe your ideal solution

In the near term, upgrading to version 1.13 isnt a problem, but this does seem like a bug since testing requirements should not be included in runtime environments. There is a tracking issue here to fix this issue in cudf.

Hopefully this will be fixed in future versions.

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added the feature request New feature or request label Jul 6, 2023
@mdemoret-nv
Copy link
Contributor Author

Closed by #346

@mdemoret-nv mdemoret-nv self-assigned this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant