Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Consolidate duplicate split_string_on and split_string_to_array methods #454

Closed
2 tasks done
dagardner-nv opened this issue Mar 12, 2024 · 0 comments · Fixed by #465
Closed
2 tasks done

[FEA]: Consolidate duplicate split_string_on and split_string_to_array methods #454

dagardner-nv opened this issue Mar 12, 2024 · 0 comments · Fixed by #465
Assignees
@dagardner-nv
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

dagardner-nv commented Mar 12, 2024 •
edited
Loading

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

These two methods are nearly identical.

split_string_to_array
split_string_on

Describe your ideal solution

Replace both of them with boost::algorithm::split or std::ranges::split_view

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Mar 12, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 5, 2024
@dagardner-nv dagardner-nv mentioned this issue Apr 5, 2024
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #465 Apr 10, 2024
rapids-bot bot pushed a commit that referenced this issue Apr 10, 2024
@dagardner-nv
Consolidate redundant split_string_to_array, split_string_on & split_…
0701b13 
…path methods (#465)

* All three methods performed nearly identical operations, but were defined in anonymous namespaces and not exposed in a header preventing sharing.
* Consolidate all three into a new `split_string_to_vector` in `string_utils.hpp`

closes #454

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate redundant split_string_to_array, split_string_on & split_path methods dagardner-nv/MRC
1 participant
@dagardner-nv