Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Optional logging for MRC nodes added by modules #477

Open
2 tasks done
dagardner-nv opened this issue Apr 26, 2024 · 0 comments
Open
2 tasks done

[FEA]: Optional logging for MRC nodes added by modules #477

dagardner-nv opened this issue Apr 26, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

Currently with Morpheus stages we log stages added to the pipeline in the form of:

Added stage: <stage> 
 └─ InputT -> OutputT

With the adoption of modules, a single module could add several MRC nodes to the pipeline. The rss_source_pipe is an example of this:
https://github.com/nv-morpheus/Morpheus/blob/branch-24.06/examples/llm/vdb_upload/module/rss_source_pipe.py

However this makes the rss_source_pipe rather opaque and unclear what is contained inside.

Describe your ideal solution

Add optional logging to module instantiation.
Would likely require tracking calls to builder.make_edge and builder.register_module_output

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant