Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Create a 'skip-ci' label #1183

Closed
2 tasks done
dagardner-nv opened this issue Sep 8, 2023 · 1 comment · Fixed by #1444
Closed
2 tasks done

[FEA]: Create a 'skip-ci' label #1183

dagardner-nv opened this issue Sep 8, 2023 · 1 comment · Fixed by #1444
Assignees
@dagardner-nv
Labels
feature request New feature or request
Milestone
24.03 - Dependenc...

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

Per our new workflows we are opening draft PRs at the start of development, rather than at the end.

To avoid spamming CI with un-needed jobs and devs needing to add [no-ci] to commit notes, we would like to have a skip-ci label, which when attached to a PR would skip CI until removed.

Describe your ideal solution

Avoid all CI jobs from running, or minimally bail early in a pre-flight job.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Sep 8, 2023
@mdemoret-nv
Copy link
Contributor

Just to add to this MRC currently has the ability to skip certain stages based on a label on the PR. This could easily be expanded to skip the rest of CI. Should look to MRC for an example implementation

@dagardner-nv dagardner-nv self-assigned this Dec 13, 2023
@dagardner-nv dagardner-nv mentioned this issue Dec 19, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Dec 20, 2023
@dagardner-nv
Optionally skip ci based on a label in the pr (#1444)
8d8842b 
* Adds a `get-pr-info` job at the head of the pipeline which examines the labels on the PR.
* If the PR contains the `skip-ci` label, the rest of the jobs in the CI pipeline are skipped.
* This avoids the requirement to include `[no ci]` in commit comments. 
* After the label is removed CI will execute on the next push.

Closes #1183

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
24.03 - Dependencies, Build System, a...
Development

Successfully merging a pull request may close this issue.

Optionally skip ci based on a label in the pr dagardner-nv/Morpheus
2 participants
@mdemoret-nv @dagardner-nv