-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]: What is the labels file for in 2_real_world_phishing? #1208
Comments
Hi @nyck33! Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can! |
Also noticed some overflow issue in the Triton server output when running this one.
|
@nyck33 Thank you for reporting this. I was able to reproduce your results. The labels file should have
I'm manually specifying the labels here. Here's an example of how to use
The overflow warnings from Triton are from automatic ONNX to TensorRT conversion we're doing here: Thanks again for reporting this. I'll create a PR to make the corrections. |
- Update labels file to reflect actual model outputs: `not_phishing` and `is_phishing` - Add `AddScores` stage to Python and CLI examples - Remove `FilterDetectionsStage` because model output contains probabilities for both `not_phishing` and `is_phishing`one of which will always exceed threshold. This results in nothing ever being filtered out. Closes #1208 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1215
How would you describe the priority of this documentation request
Medium
Describe the future/missing documentation
I look at it and it's blank:
Then after running the example I get output like: https://gist.github.com/nyck33/8cc7f8622088f16ebbbe4a5071632db4
But I can only see some
[SEP]
tokens inserted? I thought like the abp_nvsmi example I was going to get a file with either 1 or 0 to indicate whether an email was flagged as potential phishing attempt or not.The output below makes it seem like the run was successful. It took Triton inference server some time to finish, in that last line below, that started at 0 and when I came back it was 100 (left the screen because it was slow but my GPU is not that great).
Where have you looked?
https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/docs/source/developer_guide/guides/2_real_world_phishing.md
Code of Conduct
The text was updated successfully, but these errors were encountered: