Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: dfp is it all modular pipeline now since 23.03? #1222

Closed
2 tasks done
nyck33 opened this issue Sep 25, 2023 · 3 comments
Closed
2 tasks done

[DOC]: dfp is it all modular pipeline now since 23.03? #1222

nyck33 opened this issue Sep 25, 2023 · 3 comments
Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team Needs Triage Need team to review and classify

Comments

@nyck33
Copy link

nyck33 commented Sep 25, 2023

How would you describe the priority of this documentation request

Medium

Describe the future/missing documentation

A example here: https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/docs/source/developer_guide/guides/10_modular_pipeline_digital_fingerprinting.md

Then the production here: https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/examples/digital_fingerprinting/production/README.md

But if it's modular since 23.03, then the second example is modular? So there is no such thing as a staging/stages version of the dfp pipeline in branch 23.11, is that correct?

I saw in the docker compose file that it really does seem to be mimicking a production deployment with other containers for kafka, mlflow, etc being built and run which is what I wanted to try, ie. maybe even try running the example in the cloud just to get used to that environment but then came by this modular pipeline for dfp example and got confused.

Where have you looked?

see the links above and the GTC roundtable conference and DLI lesson video plus https://docs.nvidia.com/morpheus/developer_guide/guides/6_digital_fingerprinting_reference.html

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@nyck33 nyck33 added the doc Improvements or additions to documentation label Sep 25, 2023
@jarmak-nv jarmak-nv added Needs Triage Need team to review and classify external This issue was filed by someone outside of the Morpheus team labels Sep 25, 2023
@jarmak-nv
Copy link
Contributor

Hi @nyck33!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

@efajardo-nv
Copy link
Contributor

efajardo-nv commented Sep 25, 2023

@nyck33 A DFP pipeline can be built with either stages or modules. The links you provided contain examples of both approaches:

Using stages:
https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/examples/digital_fingerprinting/production/README.md#steps-to-run-example-pipeline

Using modules:
https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/docs/source/developer_guide/guides/10_modular_pipeline_digital_fingerprinting.md#morpheus-pipeline

All example DFP pipelines can be run in the same docker-compose environment.

@jarmak-nv
Copy link
Contributor

Hey @nyck33 Gonna discussion this one also!

In general we approach issues as concrete items that can be actioned on, since this is mostly a question, it should be a discussion. If something we can improve/fix/add comes out of the discussion we will spawn an issue and triage (understand + decide where in the roadmap) per normal.

@nv-morpheus nv-morpheus locked and limited conversation to collaborators Sep 25, 2023
@jarmak-nv jarmak-nv converted this issue into discussion #1223 Sep 25, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team Needs Triage Need team to review and classify
Projects
Status: Done
Development

No branches or pull requests

3 participants