Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Error running modular DFP benchmarks #1432

Closed
2 tasks done
efajardo-nv opened this issue Dec 13, 2023 · 0 comments · Fixed by #1429
Closed
2 tasks done

[BUG]: Error running modular DFP benchmarks #1432

efajardo-nv opened this issue Dec 13, 2023 · 0 comments · Fixed by #1429
Assignees
Labels
bug Something isn't working dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow

Comments

@efajardo-nv
Copy link
Contributor

efajardo-nv commented Dec 13, 2023

Version

24.03

Which installation method(s) does this occur on?

No response

Describe the bug.

Getting error running any of the modular DFP benchmarks.

Minimum reproducible example

No response

Relevant log output

self = <benchmarks.benchmark_conf_generator.BenchmarkConfGenerator object at 0x7f9d4323a470>

    def get_module_conf(self):
        """Get module configuration."""
>       dfp_arg_parser = DFPArgParser(skip_user=[],
                                      only_user=[],
                                      start_time=(datetime.strptime(self._pipe_conf.get('start_time'), '%Y-%m-%d')),
                                      log_level=logger.level,
                                      cache_dir='./.cache/dfp',
                                      sample_rate_s=0,
                                      duration=(self._pipe_conf.get('duration')),
                                      source=(self.source),
                                      tracking_uri=mlflow.get_tracking_uri(),
                                      silence_monitors=True,
                                      train_users='generic')
E       TypeError: DFPArgParser.__init__() missing 2 required positional arguments: 'mlflow_experiment_name_formatter' and 'mlflow_model_name_formatter'

benchmark_conf_generator.py:154: TypeError

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@efajardo-nv efajardo-nv added bug Something isn't working dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow labels Dec 13, 2023
@efajardo-nv efajardo-nv self-assigned this Dec 13, 2023
rapids-bot bot pushed a commit that referenced this issue Dec 13, 2023
- Fix modular DFP benchmark and examples after `DFPArgParser`updates from PR #1245
- Shorten `load` file paths in example control messages
- Doc fixes

Fixes #1431
Fixes #1432

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant