Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: re-work _verify_deps to key off of the import exception #1435

Closed
2 tasks done
dagardner-nv opened this issue Dec 13, 2023 · 0 comments · Fixed by #1443
Closed
2 tasks done

[BUG]: re-work _verify_deps to key off of the import exception #1435

dagardner-nv opened this issue Dec 13, 2023 · 0 comments · Fixed by #1443
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.03

Which installation method(s) does this occur on?

Source

Describe the bug.

Currently we check for strings in the globals dict, rather we should just save the original import error and re-raise it.

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Dec 13, 2023
@dagardner-nv dagardner-nv self-assigned this Dec 13, 2023
@dagardner-nv dagardner-nv mentioned this issue Dec 18, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Dec 20, 2023
@dagardner-nv
Refactor verification of optional dependencies (#1443)
77cbffe 
* Rather than checking keys in the `globals()` dictionary, check if the exception is not-None
* Remove `morpheus/utils/verify_dependencies.py`

Closes #1435

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor verification of optional dependencies dagardner-nv/Morpheus
1 participant
@dagardner-nv