Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Create a Langchain Tool for Morpheus LLM Services #1537

Open
2 tasks done
dagardner-nv opened this issue Feb 28, 2024 · 3 comments · May be fixed by #1633
Open
2 tasks done

[FEA]: Create a Langchain Tool for Morpheus LLM Services #1537

dagardner-nv opened this issue Feb 28, 2024 · 3 comments · May be fixed by #1633
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

This would be a subclass of langchain_core.tools.BaseTool that would allow usage of morpheus.llm.services.llm_service.LLMClient's from a LangChain agent.

Describe your ideal solution

Ideally this would receive either an LLMClient instance as a constructor argument, or an LLMService with the keyword args needed to call get_client.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Feb 28, 2024
@aserGarcia
Copy link
Contributor

Interested in working on this.

@mdemoret-nv mdemoret-nv linked a pull request May 9, 2024 that will close this issue
Open
@mdemoret-nv
Copy link
Contributor

@aserGarcia Our development team has been working on the LLM services lately and we have a prototype of this feature already created here. Just wanted to let you know before you started working on this issue.

We appreciate your contributions lately. I just merged your PR. Would be happy to discuss other features you might be interested in working on.

@aserGarcia
Copy link
Contributor

Awesome! Glad it's getting implemented. Thanks for the heads up.

I was considering this improvement since it's been open for a while:
#1377 (Update SID with credential detection rules)

But I am also open to whatever helps the team there from the sidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DO NOT MERGE] PR to hold the changes for Cyber Dev Day mdemoret-nv/Morpheus
3 participants
@aserGarcia @mdemoret-nv @dagardner-nv