You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This would allow pipelines like Hammah, where some stages have C++ impls, to run in a hybrid mode.
Describe the solution you'd like
There are a few message classes which don't have C++ impls but inherit from a message class that has a C++ impl. Typically these only add a few attributes.
Describe alternatives you've considered
Options would be:
Just add the new C++ message classes (I have some of them in an old branch).
Investigate pybind11 trampoline classes
The text was updated successfully, but these errors were encountered:
What if we just had a limited number of message types, and those messages types were simply data frames (for batch messages) or a single row (for non-batched types), and we had an associated list of available attributes on those messages? So rather than a hierarchy of messages classes, each stage would get it's own ingress and egress manifest, where each row must conform to the manifest? essentially we type-erase the message itself, and the associated manifest is the source of truth for type checking. This limits us to "has column with type" sorts of type checks, but that's probably good enough. Thoughts?
I think this could work for us, but would likely require us to remove the python impls for the message classes which have a C++ impl. Such that the message classes without a C++ impl are always inheriting from the C++ base.
Personally I think this is a good thing, and would remove the need to maintain redundant Python & C++ impls for the same classes.
What if we just had a limited number of message types,... This limits us to "has column with type" sorts of type checks, but that's probably good enough. Thoughts?
Maybe I'm mis-understanding what your proposing, but I'm not sure that would work for the inference & response messages MultiInferenceMessage & MultiResponseMessage which in addition to the dataframe contain a set of tensors. Specifically the amount of heavy lifting those classes are doing to ensure the offsets are properly calculated for both the dataframe & tensors.
Is your feature request related to a problem? Please describe.
This would allow pipelines like Hammah, where some stages have C++ impls, to run in a hybrid mode.
Describe the solution you'd like
There are a few message classes which don't have C++ impls but inherit from a message class that has a C++ impl. Typically these only add a few attributes.
Describe alternatives you've considered
Options would be:
The text was updated successfully, but these errors were encountered: