-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake deprecation error < 3.5 #120
Comments
we could bump the minimum_required cmake version to idk 3.9 |
We can try to see if it fixes this issue. |
The real issue is in the build command advertised by the plugin. The final install step fails at
At first look this install step is entirely redundant. On second look its dangerous because it is undefined behavior which new versions of cmake seem to have affected. So PSA for people coming here: - cmake --build build --config Release && \
- cmake --install build --prefix build",
+ cmake --build build --config Release", Alternatively use |
Recent versions of cmake seem to affect how redundant installation directives are handled, i.e. install source and destination are the same. While previously they went through as a noop, they now seem to fail as reproduced in nvim-telescope#120.
Recent versions of cmake seem to affect how redundant installation directives are handled, i.e. install source and destination are the same. While previously they went through as a noop, they now seem to fail as reproduced in #120.
I get the same issue, also on NixOS. I tried changing the build command in my lua config to both 'make' and 'cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=Release && cmake --build build --config Release' and it did not seem to change anything; I still get the issue. I did, however, find a workaround: just go to your shell and manually run make:
|
I ran into the same issue on Nix using LazyVim. Seems they check whether |
I'm using NixOS with Neovim. Installing telescope-fzf-native.nvim by the following
telescope.lua
file:and when I place
telescope.lua
among the plugins of Neovim, when I runnvim
for the first time, at compilation time of this plugin I getIn
plugins.lua
it is dealt with:Why I get this deprecation error despite I'm using CMake 3.27? The problem is in
CMakeLists.txt
at:?
The text was updated successfully, but these errors were encountered: