You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
lsp_definitions would jump to the location if there was only one result, but it would not do so if such scenario was due to file_ignore_patterns, resulting in a list of a single location without automatic jumping.
Describe the solution you'd like
Maybe it should check (in list_or_jump I think?) the result after filtering, instead of before filtering? Not 100% sure about the implementation details behind this.
Describe alternatives you've considered
Or just leave it as is. I don't think you would encounter this in any sensible code base.
Additional context
I encountered this when I was to filter out the generated code in Unity's UIToolkit. Personally I think they introduced a solution to a non-existing problem, but wcyd. The example below should be reproducible in any language where multiple definitions can happen.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
lsp_definitions would jump to the location if there was only one result, but it would not do so if such scenario was due to file_ignore_patterns, resulting in a list of a single location without automatic jumping.
Describe the solution you'd like
Maybe it should check (in list_or_jump I think?) the result after filtering, instead of before filtering? Not 100% sure about the implementation details behind this.
Describe alternatives you've considered
Or just leave it as is. I don't think you would encounter this in any sensible code base.
Additional context
![Capture2](https://private-user-images.githubusercontent.com/17314075/339621192-e78ab02d-889c-40fd-bc03-57dbe5d8b833.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NDIxMzIsIm5iZiI6MTcxOTU0MTgzMiwicGF0aCI6Ii8xNzMxNDA3NS8zMzk2MjExOTItZTc4YWIwMmQtODg5Yy00MGZkLWJjMDMtNTdkYmU1ZDhiODMzLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAyMzAzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjYjRhNjNhZjc5ZGRhMGM5M2QyNzRhY2ZjYzNlMDRlYjFjYWU2YTBlMzgzNDZiNTlkYTVkNmU2OTBmZjY4ZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sRB6wIOaHhknQ1WkzXSNyXy0mC2xTlSU8aqXLW30mPo)
![Capture](https://private-user-images.githubusercontent.com/17314075/339621175-bdc150cc-1d71-4c4b-a183-9e3c813ca96c.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NDIxMzIsIm5iZiI6MTcxOTU0MTgzMiwicGF0aCI6Ii8xNzMxNDA3NS8zMzk2MjExNzUtYmRjMTUwY2MtMWQ3MS00YzRiLWExODMtOWUzYzgxM2NhOTZjLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAyMzAzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmMDZlMDc2YTg1MDRmODIyMDI2YWM2ZjBlZjFmOWE1ZTE0M2E4OGQwMmYwODBmNjZjNGE0ZTExNGYyZGEzNTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9gC-VKrXXIVb-oxuXEmAy0SrD7GCc4InawgKwjRYiIw)
I encountered this when I was to filter out the generated code in Unity's UIToolkit. Personally I think they introduced a solution to a non-existing problem, but wcyd. The example below should be reproducible in any language where multiple definitions can happen.
The text was updated successfully, but these errors were encountered: