Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if linking should be disable-able #1

Open
nvzqz opened this issue Sep 11, 2020 · 0 comments
Open

Determine if linking should be disable-able #1

nvzqz opened this issue Sep 11, 2020 · 0 comments
Milestone
v1.0.0

Comments

@nvzqz
Copy link
Owner

nvzqz commented Sep 11, 2020

It might make sense to have a link (on by default) or no-link feature flag.

Further investigation needs to be done to determine:

  1. Is this worth having?
  2. What is the added complexity?
  3. How can this break things for end users of this lib?
  4. Which feature flag is "safer"?
  5. Which feature flag aligns more with the philosophy of being additive?
@nvzqz nvzqz added this to the v1.0.0 milestone Sep 11, 2020
nvzqz added a commit that referenced this issue Sep 11, 2020
@nvzqz
Remove "link" feature
a9a0ef2 
This is being tracked in issue #1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@nvzqz