Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature requset] River support #30

Open
Sunderland93 opened this issue Sep 4, 2023 · 6 comments
Open

[Feature requset] River support #30

Sunderland93 opened this issue Sep 4, 2023 · 6 comments

Comments

@Sunderland93
Copy link
Contributor

https://github.com/riverwm/river

@nwg-piotr
Copy link
Owner

Basically nwg-shell and its components are for sway and Hyprland. By adding support for other window managers (such as DWL tags in nwg-panel), I know that I won't use it myself, so the option may be poorly tested and not further developed. At the moment the answer is no. Perhaps on long winter evenings.

@nwg-piotr nwg-piotr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
@midirhee12
Copy link

midirhee12 commented Jul 2, 2024

@nwg-piotr I would be happy to maintain and test for riverwm support.

Please re-open so I can contribute.

@nwg-piotr
Copy link
Owner

@cvoges12 - sure, go ahead.

@nwg-piotr nwg-piotr reopened this Jul 2, 2024
@midirhee12
Copy link

I'm going to notate all the places where sway / hyprland dependent code is taking place and start adding the riverwm equivalents.

So far I've found:

  • getting the SWAYSOCK and/or HYPRLAND_INSTANCE_SIGNATURE
  • getting the path of the .config directory for sway and hyprland
  • creating the corresponding outputs/monitors and workspaces files
  • list of active outputs (from sway tree)

I'll keep listing as I go through. I've noticed that there are some generically named functions and such that are only being used for sway. I'll refactor and rename these before I continue to ease the process. I'll send a PR regarding this change separately since it should probably be done anyways regardless if the changes for this issue get merged or not.

@nwg-piotr
Copy link
Owner

Keep in mind that I'm only going to test your changes on sway and Hyprland. River-related stuff remains your responsibility.

@midirhee12
Copy link

Yep, I'm fully aware. Right now I'm just trying to get a sense of the project and where all the compositor specific code is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants