Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary installation of node.js instead of HostBuild #1547

Open
artynet opened this issue Apr 21, 2023 · 3 comments
Open

Binary installation of node.js instead of HostBuild #1547

artynet opened this issue Apr 21, 2023 · 3 comments

Comments

@artynet
Copy link
Contributor

artynet commented Apr 21, 2023

Hello @nxhack,

I have come up with a simple hack to speed up the overall node.js build. Instead of compiling the sources for the local build, wouldn't it be simpler to download the binary tarball and extract it in the $(STAGING_DIR_HOSTPKG) folder ? Please take a look at my modification to main the the main node package Makefile here:

artynet@79565b1

looking forward to know about you feedback.....

Kind Regards

@nxhack
Copy link
Owner

nxhack commented Apr 22, 2023

Hi @artynet

Your ideas are simple and effective. Thank you.
However, some packages depend on 'node/host'.

  • cloudreve
  • adguardhome
  • transmission

That will be a concern.

@nxhack
Copy link
Owner

nxhack commented Apr 22, 2023

The other thing I found out is that we need to consider macos and WSL as build environments for OpenWrt other than Linux.

There is an official node.js binary package for macos, but not for WSL, although it can be installed using apt.

As a hobby of mine ;) I have been able to build OpenWrt on FreeBSD.

@nxhack
Copy link
Owner

nxhack commented May 8, 2023

I will add an option to support only linux 64bit host. I'm a bit busy right now, so implementation will come a bit later.

nxhack added a commit that referenced this issue May 9, 2023
Install the official nodejs binary package as HOSTPKG.
Reduce build time for host package.

This change was suggested by @artynet

#1547

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
nxhack added a commit that referenced this issue May 9, 2023
Install the official nodejs binary package as HOSTPKG
Reduce build time for host package.

This change was suggested by @artynet

#1547

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
nxhack added a commit that referenced this issue May 9, 2023
Install the official nodejs binary package as HOSTPKG
Reduce build time for host package.

This change was suggested by @artynet

#1547

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
(cherry picked from commit 1767ca6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants