Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for dark theme #470

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update for dark theme #470

wants to merge 3 commits into from

Conversation

kostek00
Copy link

@kostek00 kostek00 commented Apr 7, 2018

I was asked by Anna-Maria Meriniemi if I would like to make pull request with my DeepDark Nyaa.si style in stylish for official Nyaa repo. So here it is. I cleaned most of it from unnesesery code. I hope it's not too chaotic and noobish.

@TheAMM
Copy link
Contributor

TheAMM commented Apr 7, 2018

Nice! I'll give this a better look later. Some of the rows will require colors (hidden and deleted torrents which the normal users don't really get to see) and IMO some of the :visited colors are too dark to separate from the background. But I consider this an improvement on the current dark CSS.

Here are some screenshots:
image
image
image

@kostek00
Copy link
Author

kostek00 commented Apr 7, 2018

I was wondering if hidden torrents are hidden even for admin (I was assuming they aren't but still). When it comes to deleted torrents I see only 2 ways. Leave them as bright grey with dark font color or give them some different color. When it come to :visited I was thinking to make them the same color as not :visited but I decided to give them darker color. I will see tommorow what can I do with that but it will be hard.

By the way I see quoteblock not looking for you as it should.

Edit: I know why. Somewhere in the middle of checking I must have deleted it.

@kostek00
Copy link
Author

kostek00 commented Apr 8, 2018

I forgot to ask. Does hidden torrents have it's own class on torrent list or only in line style as in torrent view? Because I do have color theme for it already implemented in my style. I just don't know what I have to target. And how does it look in code?

@TheAMM
Copy link
Contributor

TheAMM commented Apr 8, 2018

Here's the template line for the torrent CSS class:
https://github.com/nyaadevs/nyaa/blob/master/nyaa/templates/search_results.html#L60
It is a bit hacky, since we're using the bootstrap defaults but also provide our own deleted.

Here's the torrent page's class choosing:
https://github.com/nyaadevs/nyaa/blob/master/nyaa/templates/view.html#L9
Right now we use an inline style for deleted torrents on the torrent page, so don't worry about that.

@kostek00
Copy link
Author

kostek00 commented Apr 8, 2018

I see. Everything is clear now. I will make those today or tommorow.

@kostek00
Copy link
Author

kostek00 commented Apr 9, 2018

I will explain changes.

Instead of making :visited links darker I took different approach. I made them almost greyed out. They do retain a little bit of their color but I doubt anyone will see difference. I couldn't make it any other way otherwise links would be too dark. There is another way to deal with them. Instead of changing their color they can have checkmark before link with image. Most browsers won't allow for :visited:before so there is no point in doing so with content.

For deleted torrents I didn't use another pair of grey colors. Belive me you don't want grey rainbow you can go crazy looking at that. On the other hand I didn't want to use light grey to make bigger difference between them and not deleted because it's not how dark theme should look like. I spared you madness and made them blue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants