-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master_event_id key not present in typings for Event class #221
Comments
I found another key missing: original_start_time/originalStartTime |
Is there any input from the contributing team on this repo? It seems odd that instructions on how to contribute are provided, and then the permissions on this repository are such that the instructions cannot be adhered to (labeling issues for example). |
Hey @ahathaway! Thanks for tackling this issue, you are more than welcome to submit a PR! Can you describe what issues you are seeing when attempting to create a PR? I can try to help resolve those issues so we can get the PR started and eventually merged in 😄 |
Ran into the same issue. Currently manually extending Event right now to access conferencing, originalStartTime and masterEventId, and sending requests with Axios. https://developer.nylas.com/docs/api/#tag--Events--events-object (Conferencing isn't available in the above docs, but is available from the API) Data from the API w/ original values changed:
|
This has been removed again from the types, I check this PR you referenced, there was an event.ts but now its events.ts and the masterEventId has been excluded again |
Reopening this issue, thanks @horlaarsco we'll take a look as soon as we get a chance! |
Same seems to be true for resources[] |
I am not sure if this qualifies as a bug or a feature request, I suppose an argument could be made for either. Because I am unsure, I will post my suggested fix here and I am also happy to create a PR to introduce the change if the owners of this repository agree.
I have changes ready to PR here: https://github.com/ahathaway/nylas-nodejs
I am currently using the updated version in my integration, would love to see this pulled into the nylas repo so that I can switch back.
Current typings for Event class in file: node_modules/nylas/lib/models/event.d.ts
Unfortunately, when there is a recurrence pattern for an event series, and then the user deletes one of those instances (thus producing an override), Nylas sends a different object over the webhook:
Notice the
master_event_id
which indicates that the item is an override event for a series.I believe this should be added to the type definition as:
masterEventId?: string;
Like so:
Thoughts on this?
The text was updated successfully, but these errors were encountered: