Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link to a Flickr image gives me an 'undefined' link on the content profile #3169

Closed
bertpareyn opened this issue Aug 20, 2013 · 10 comments
Assignees

Comments

@bertpareyn
Copy link
Contributor

screen shot 2013-08-20 at 16 29 11

The Flickr link used: http://www.flickr.com/photos/bertpareyn/9009115086/
Another Flickr link that did work: http://www.flickr.com/photos/iandolphin/9551168427/

@nicolaasmatthijs
Copy link
Contributor

Assigning to @BP323 for investigation

@ghost ghost assigned bertpareyn Aug 20, 2013
@simong
Copy link
Contributor

simong commented Aug 20, 2013

FWIW: The PP sets the previews.status to ignored. Maybe the preview widget is ignoring the ignore status?

@bertpareyn
Copy link
Contributor Author

The Hilary logs produce this for the link:

[2013-08-21T07:12:59.036Z] ERROR: oae-preview-processor/4023 on ds159.lib.private.cam.ac.uk: Could not check whether this URL allows for iframe embedding. (contentId=c:cam:xJGtEmkROg)
    Error: Parse Error
        at Socket.socketOnData (http.js:1553:20)
        at TCP.onread (net.js:525:27)

@bertpareyn
Copy link
Contributor Author

@simong The PP locally returns status error

@simong
Copy link
Contributor

simong commented Aug 21, 2013

You probably haven't filled in the flickr API keys so it falls back to the default link processor.
That does a HEAD request to check for iframe embedding but I don't see why that would fail.

I'll dig into it a bit

@ghost ghost assigned simong Aug 21, 2013
@simong
Copy link
Contributor

simong commented Aug 21, 2013

I suspect this is because we're doing a HEAD request that gets redirected (twice) and ends up at an https endpoint. The actual error is { [Error: Parse Error] bytesParsed: 829, code: 'HPE_INVALID_CONSTANT' }

@nicolaasmatthijs
Copy link
Contributor

If this is the only URL that this is really happening for, we probably don't need to fix the preview processor issue as we expect people to configure the Flickr API key. However, the UI should be able to deal with the error status code rather than showing the undefined message.

@simong
Copy link
Contributor

simong commented Aug 23, 2013

I've created an issue in the backend (oaeproject/Hilary#645) to track the backend part of this issue.

I'll assign this (UI) ticket to @BP323 for dealing with preview errors.

@ghost ghost assigned bertpareyn Aug 23, 2013
@bertpareyn
Copy link
Contributor Author

I created a ticket for this in the plugin's Github repo starfishmod/jquery-oembed-all#93

@nicolaasmatthijs
Copy link
Contributor

Closing this in favour of the Github repo ticket. I've also signed up for thread updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants