Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Netlify GitHub App for PR preview #19

Open
tomkerkhove opened this issue Jan 3, 2020 · 1 comment
Open

Install Netlify GitHub App for PR preview #19

tomkerkhove opened this issue Jan 3, 2020 · 1 comment

Comments

@tomkerkhove
Copy link
Contributor

tomkerkhove commented Jan 3, 2020

I've noticed Netlify is being used for hosting the content based on https://github.com/oam-dev/oam-dev.github.io/blob/dev/netlify.toml

The Netlify GitHub App could be use to build a preview of the website in a PR so that it can be reviewed as it would be deployed.

For an example, see tomkerkhove/promitor#766 which generated https://deploy-preview-766--promitor-staging.netlify.com/. I'm not using Netlify for my PROD site so it would be https://deploy-preview-766--oam.netlify.com/.

@flynnduism
Copy link
Member

The site used Netlify for earlier dev and staging work, but the live site is actually hosted on Github Pages.

live site     -->   oam-dev.github.io
staging site  -->   oamdev.netlify.com

I'd prefer to use Netlify as well as their continuous deployment for Hugo static sites is smoother than Github Pages. Currently we have to run these steps to deploy. Plus the deploy previews you mention on pull requests is a great feature.


@vturecek what do you think? What we have right now works. Changing would require a DNS edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants