Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add childResource to OAM definition spec #410

Open
resouer opened this issue Oct 5, 2020 · 3 comments
Open

Add childResource to OAM definition spec #410

resouer opened this issue Oct 5, 2020 · 3 comments
Milestone

Comments

@resouer
Copy link
Member

resouer commented Oct 5, 2020

It has been proved that childResource is a strong need for any abstraction workload (e.g. ContainerizedWorkload), so that Trait controller could know what's the underlying workload object it need to handle with, see: this example. Note that this field is Kubernetes specific for now, but it has been proven to be a generic field required by various implementations.

--- Off Topic ---

That being said, we may also want to add a runtime field to definition object in the future so we can add runtime specific configurations in the definition object? For example:

apiVersion: v1alpha2
kind: TraitDefinition
spec:
  runtimePlatform: Kubernetes
 ...
apiVersion: v1alpha2
kind: TraitDefinition
spec:
  runtimePlatform: ServiceFabric
 ...
apiVersion: v1alpha2
kind: TraitDefinition
spec:
  runtimePlatform: AlibabaCloudFaaS
 ...
@resouer resouer added this to the v0.2.2 milestone Oct 5, 2020
@resouer
Copy link
Member Author

resouer commented Oct 5, 2020

/cc @ryanzhang-oss @wonderflow

@ryanzhang-oss
Copy link
Contributor

I think it's better to create a separate issue on the "runtime", it deserves its own issue :)

@wonderflow
Copy link
Member

I agree this proposal, what about make runtimePlatform: Kubernetes as default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants