Skip to content

Description of test 6.1.34 needs clarification #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oxisto opened this issue Dec 8, 2024 · 2 comments
Closed

Description of test 6.1.34 needs clarification #840

oxisto opened this issue Dec 8, 2024 · 2 comments
Assignees
Labels
documentation editorial mostly nits and consistency question

Comments

@oxisto
Copy link
Contributor

oxisto commented Dec 8, 2024

Consider this (partial) JSON:

{
    "product_tree": {
        "branches": [
            {
                "branches": [
                    {
                        "category": "vendor",
                        "name": "Example Company",
                        "product": {
                            "name": "Example Product",
                            "product_id": "1"
                        }
                    }
                ],
                "category": "vendor",
                "name": "Example Company"
            },
            {
                "branches": [
                    {
                        "category": "vendor",
                        "name": "Example Company",
                        "product": {
                            "name": "Example Product",
                            "product_id": "1"
                        }
                    }
                ],
                "category": "vendor",
                "name": "Example Company"
            },
            /* ... repeat 30 times */
        ]
    }
}

This has a recursion depth of 2, which is ok according to the definition of the max branch depth. But the test specifies that "it MUST be tested that the complete JSON path does not contain more than 30 instances of branches.". This has the problem that instances of branches can exist next to each other and we need to consider the maximum depth of each of these instances.

@tschmidtb51
Copy link
Contributor

@oxisto Please provide a suggestion for improved wording.

@oxisto
Copy link
Contributor Author

oxisto commented Apr 22, 2025

@oxisto Please provide a suggestion for improved wording.

After re-reading the sentence very carefully I think its actually ok the way it is, since it says that the JSON path does not contain more than 30 instances of branches and the JSON path of a nested branches-structure would contain them, but one that is next to each other would not.

@oxisto oxisto closed this as completed Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation editorial mostly nits and consistency question
Projects
None yet
Development

No branches or pull requests

3 participants