Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/ts-web: bump typescript from 4.3.5 to 4.4.2 in /client-sdk/ts-web #389

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 27, 2021

Bumps typescript from 4.3.5 to 4.4.2.

Release notes

Sourced from typescript's releases.

TypeScript 4.4.2

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.4 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.4 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added c:client-sdk/typescript Category: TypeScript client SDK c:deps Category: external dependencies labels Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #389 (fd04187) into main (5904d3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   70.33%   70.33%           
=======================================
  Files          88       88           
  Lines        5556     5556           
=======================================
  Hits         3908     3908           
  Misses       1628     1628           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5904d3d...fd04187. Read the comment docs.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/typescript-4.4.2 branch 4 times, most recently from 728ac9f to 2d64cd3 Compare August 27, 2021 12:31
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the release announcement sounds good. I'll see about getting our codebase compliant with the new stuff

@pro-wh
Copy link
Contributor

pro-wh commented Aug 27, 2021

image

that's weird, doesn't autofocus still exist?

@pro-wh
Copy link
Contributor

pro-wh commented Aug 27, 2021

image

I can still jump to declaration from .autofocus in vscode, but it leads to some weird /usr/share/code place

@pro-wh
Copy link
Contributor

pro-wh commented Aug 27, 2021

@pro-wh
Copy link
Contributor

pro-wh commented Aug 27, 2021

good timing, someone reported this microsoft/TypeScript-DOM-lib-generator#1029 (comment)

let's hold off on merging this until we get an answer there

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/typescript-4.4.2 branch 3 times, most recently from 26e3979 to b144238 Compare August 30, 2021 09:29
@pro-wh
Copy link
Contributor

pro-wh commented Aug 30, 2021

Someone said that it's already fixed in TypeScript-DOM-lib-generator. I guess now all we need is for typescript to import a new copy of the types and to make a new release.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/typescript-4.4.2 branch 10 times, most recently from 9b98c98 to 7578759 Compare September 7, 2021 20:04
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.5 to 4.4.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.3.5...v4.4.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/typescript-4.4.2 branch from 7578759 to fd04187 Compare September 7, 2021 20:26
@pro-wh
Copy link
Contributor

pro-wh commented Sep 8, 2021

I'm going to close this so that it doesn't pile up in our CI queue. we're only waiting for the next release at this time.

@pro-wh pro-wh closed this Sep 8, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 8, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/client-sdk/ts-web/typescript-4.4.2 branch September 8, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:client-sdk/typescript Category: TypeScript client SDK c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant