From af7332c2ee15f9602baada02a703dfc8fb3a21e0 Mon Sep 17 00:00:00 2001 From: olga-kulish Date: Tue, 4 Feb 2025 12:05:16 +0300 Subject: [PATCH 1/7] feat: vertical-writing: scroll container size --- scss/inc/_test-layout.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scss/inc/_test-layout.scss b/scss/inc/_test-layout.scss index cb8be5fc..3778c94b 100644 --- a/scss/inc/_test-layout.scss +++ b/scss/inc/_test-layout.scss @@ -175,3 +175,9 @@ .no-controls .test-runner-scope { height: 100vh; } + +.item-writing-mode-vertical-rl { + & #qti-content { + height: 100%; + } +} From 662fd2f8e294c44781e72ef697f40a8ddca47c6a Mon Sep 17 00:00:00 2001 From: olga-kulish Date: Thu, 6 Feb 2025 10:52:43 +0300 Subject: [PATCH 2/7] fix: vertical-writing: ininechoice tooltip: define scroll-container inside js bundle --- scss/inc/_test-layout.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scss/inc/_test-layout.scss b/scss/inc/_test-layout.scss index 3778c94b..01a4914e 100644 --- a/scss/inc/_test-layout.scss +++ b/scss/inc/_test-layout.scss @@ -143,6 +143,11 @@ padding: 30px; } + .qti-itemBody.writing-mode-vertical-rl { + writing-mode: vertical-rl; + overflow: auto; + } + .size-wrapper { max-width: map-get($widths, size-wrapper) * 1px; margin: auto; From fa435bd1390fb114e642dc9395fd0d5e6493de4e Mon Sep 17 00:00:00 2001 From: olga-kulish Date: Fri, 7 Feb 2025 10:32:53 +0300 Subject: [PATCH 3/7] fix: vertical-writing: inline container height styles --- scss/inc/_test-layout.scss | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/scss/inc/_test-layout.scss b/scss/inc/_test-layout.scss index 01a4914e..ddc0cccb 100644 --- a/scss/inc/_test-layout.scss +++ b/scss/inc/_test-layout.scss @@ -143,11 +143,6 @@ padding: 30px; } - .qti-itemBody.writing-mode-vertical-rl { - writing-mode: vertical-rl; - overflow: auto; - } - .size-wrapper { max-width: map-get($widths, size-wrapper) * 1px; margin: auto; @@ -186,3 +181,11 @@ height: 100%; } } +.qti-itemBody.writing-mode-vertical-rl { + writing-mode: vertical-rl; + block-size: 100%; + inline-size: 100%; + overflow: auto; + overscroll-behavior: contain; + line-height: 1.8; /* assuming ruby tags */ +} From 5c085fad36e32d293342f098c5b6cc8c6ce0c258 Mon Sep 17 00:00:00 2001 From: olga-kulish Date: Tue, 11 Feb 2025 08:16:13 +0300 Subject: [PATCH 4/7] fix: vertical writing: item padding --- scss/inc/_test-layout.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scss/inc/_test-layout.scss b/scss/inc/_test-layout.scss index ddc0cccb..6ce0c745 100644 --- a/scss/inc/_test-layout.scss +++ b/scss/inc/_test-layout.scss @@ -177,12 +177,16 @@ } .item-writing-mode-vertical-rl { - & #qti-content { + & #qti-content { height: 100%; } + .qti-item { + padding: 15px; + } } .qti-itemBody.writing-mode-vertical-rl { writing-mode: vertical-rl; + padding: 15px; block-size: 100%; inline-size: 100%; overflow: auto; From 3df08e61c0ce73b83ef3a028d9008bbf5488380b Mon Sep 17 00:00:00 2001 From: olga-kulish Date: Wed, 19 Feb 2025 12:58:15 +0300 Subject: [PATCH 5/7] refactor: css selector --- scss/inc/_test-layout.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/inc/_test-layout.scss b/scss/inc/_test-layout.scss index 6ce0c745..fddf377c 100644 --- a/scss/inc/_test-layout.scss +++ b/scss/inc/_test-layout.scss @@ -177,7 +177,7 @@ } .item-writing-mode-vertical-rl { - & #qti-content { + #qti-content { height: 100%; } .qti-item { From 320746e522c69ae1bbd52f6bbfa12e50891d76c8 Mon Sep 17 00:00:00 2001 From: olga-kulish Date: Wed, 19 Feb 2025 17:31:21 +0300 Subject: [PATCH 6/7] chore: update tao-item-runner-qti & tao-core-ui & tao-core-libs --- package-lock.json | 24 ++++++++++++------------ package.json | 6 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/package-lock.json b/package-lock.json index ecdaf9dd..b1863ea9 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,11 +16,11 @@ "@oat-sa/eslint-config-tao": "^2.0.0", "@oat-sa/prettier-config": "^0.1.1", "@oat-sa/rollup-plugin-wildcard-external": "^1.0.0", - "@oat-sa/tao-core-libs": "^1.0.0", + "@oat-sa/tao-core-libs": "^1.1.0", "@oat-sa/tao-core-sdk": "^3.0.0", - "@oat-sa/tao-core-ui": "^3.0.1", + "@oat-sa/tao-core-ui": "^3.10.0", "@oat-sa/tao-item-runner": "^1.0.0", - "@oat-sa/tao-item-runner-qti": "^2.0.1", + "@oat-sa/tao-item-runner-qti": "^2.6.0", "@oat-sa/tao-qunit-testrunner": "^2.0.0", "@oat-sa/tao-test-runner": "^1.0.0", "async": "0.2.10", @@ -2671,9 +2671,9 @@ } }, "node_modules/@oat-sa/tao-core-libs": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/@oat-sa/tao-core-libs/-/tao-core-libs-1.0.0.tgz", - "integrity": "sha512-XYoJfq2IRmt9Bx3ACe3RsZDkUICn6IhGLn23WD3WFWMDTU+xuQBL7X3Af98iEcs+xAfZpoldCfVhhAeQx3O9qQ==", + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/@oat-sa/tao-core-libs/-/tao-core-libs-1.1.0.tgz", + "integrity": "sha512-lmQIyH8FNCetEGt/93QCrgzlEftrcgLNcJjsrFyry2TCIiXevcTKldLwBBLZPNmhgAc+uX5b/c5N8ZdUm/2TEQ==", "dev": true, "peerDependencies": { "async": "0.2.10", @@ -2703,9 +2703,9 @@ } }, "node_modules/@oat-sa/tao-core-ui": { - "version": "3.0.1", - "resolved": "https://registry.npmjs.org/@oat-sa/tao-core-ui/-/tao-core-ui-3.0.1.tgz", - "integrity": "sha512-wfISAGkAil45HUUq3Nq0xFesBSRkPvr8vPrPEzqQBNjD+Nb4UeybzxXD+pRl1bNPzlg76zcfuDBLElElNv+6dw==", + "version": "3.10.0", + "resolved": "https://registry.npmjs.org/@oat-sa/tao-core-ui/-/tao-core-ui-3.10.0.tgz", + "integrity": "sha512-Exa1seoYJPQ2CjAOxyEfbe3BN5N+z7bxue74ApwGiSkPl4bMBTZDzKK4F++qBcFbxUdPSM8KWcJw36baidlR8g==", "dev": true }, "node_modules/@oat-sa/tao-item-runner": { @@ -2715,9 +2715,9 @@ "dev": true }, "node_modules/@oat-sa/tao-item-runner-qti": { - "version": "2.0.1", - "resolved": "https://registry.npmjs.org/@oat-sa/tao-item-runner-qti/-/tao-item-runner-qti-2.0.1.tgz", - "integrity": "sha512-P7JFmf48EuahXrnMmeK0k24+GMilJeo4MyglUnMAc+hjkoILyfTmCnNDWRCX+kOKuxn3B6bQT2ZwSzR0hxossA==", + "version": "2.6.0", + "resolved": "https://registry.npmjs.org/@oat-sa/tao-item-runner-qti/-/tao-item-runner-qti-2.6.0.tgz", + "integrity": "sha512-bPJqHj5ZNbDhE4TXSNt4PMeVkPpSFPRk6uTb2hRrCr+zTUM5Q6wYCnuc41116LgHn/O0X0JDl4hwXy2pcL/e0Q==", "dev": true }, "node_modules/@oat-sa/tao-qunit-testrunner": { diff --git a/package.json b/package.json index 9f28f6d0..0fe7a418 100644 --- a/package.json +++ b/package.json @@ -57,11 +57,11 @@ "@oat-sa/eslint-config-tao": "^2.0.0", "@oat-sa/prettier-config": "^0.1.1", "@oat-sa/rollup-plugin-wildcard-external": "^1.0.0", - "@oat-sa/tao-core-libs": "^1.0.0", + "@oat-sa/tao-core-libs": "^1.1.0", "@oat-sa/tao-core-sdk": "^3.0.0", - "@oat-sa/tao-core-ui": "^3.0.1", + "@oat-sa/tao-core-ui": "^3.10.0", "@oat-sa/tao-item-runner": "^1.0.0", - "@oat-sa/tao-item-runner-qti": "^2.0.1", + "@oat-sa/tao-item-runner-qti": "^2.6.0", "@oat-sa/tao-qunit-testrunner": "^2.0.0", "@oat-sa/tao-test-runner": "^1.0.0", "async": "0.2.10", From ef25c903e46c9a831011ffab8c2cd6de6474a287 Mon Sep 17 00:00:00 2001 From: oat-github-bot Date: Wed, 19 Feb 2025 14:35:33 +0000 Subject: [PATCH 7/7] chore: bump version --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index b1863ea9..543cb3e8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@oat-sa/tao-test-runner-qti", - "version": "4.1.0", + "version": "4.2.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@oat-sa/tao-test-runner-qti", - "version": "4.1.0", + "version": "4.2.0", "license": "GPL-2.0", "devDependencies": { "@babel/core": "^7.21.4", diff --git a/package.json b/package.json index 0fe7a418..f91a07c5 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@oat-sa/tao-test-runner-qti", - "version": "4.1.0", + "version": "4.2.0", "description": "TAO Test Runner QTI implementation", "files": [ "dist",