Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying compression requirements #156

Open
cobward opened this issue Jul 8, 2024 · 1 comment
Open

Simplifying compression requirements #156

cobward opened this issue Jul 8, 2024 · 1 comment
Labels
Milestone

Comments

@cobward
Copy link

cobward commented Jul 8, 2024

I have some concerns about the complexity of the compression requirements:

  1. The byte array is compressed using DEFLATE [RFC1951] with the
    ZLIB [RFC1950] data format. Implementations are RECOMMENDED to
    use the highest compression level available.

and

The HTTP response SHOULD use gzip Content-Encoding as defined in
[RFC9110].

The first quoted requirement adds needless complexity and computation on the part of the issuer, as compression can happen at the HTTP level (as indicated by the second requirement), so an implementation following the recommendations of this specification would end up compressing twice at the highest available compression level. With the second requirement there is ambiguity with how it interacts with the requirements in RFC9110 with respect to handling the Accept-Encoding request header.

My proposal is to remove the requirement for DEFLATE compression on internal structure, and instead rely solely on compression of the entire response using the request/response mechanism defined in RFC9110, section 8.4.

@paulbastian
Copy link
Contributor

paulbastian commented Aug 29, 2024

Editors Call:

  • we would like have low size for other transport protocols
  • we may not 100% rely on HTTP compression in cases where HTTP headers get lost, e.g. some reverse proxy configurations
  • we could imagine compression_alg as an optional parameter that defaults to zlib, but could be none

@paulbastian paulbastian added this to the -05 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants