Skip to content

Commit 584860f

Browse files
authored
Merge pull request #88 from oauthstuff/danielfett/romans-feedback
Address Roman's comments
2 parents e8f3803 + 0ec325a commit 584860f

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

A02_recommendations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ Under the conditions described in (#client_impersonating_countermeasures),
230230
authorization servers SHOULD NOT allow clients to influence their `client_id` or
231231
any claim that could cause confusion with a genuine resource owner.
232232

233-
It is RECOMMENDED to use end-to-end TLS between the client and the resource server. If TLS
233+
It is RECOMMENDED to use end-to-end TLS according to [@!BCP195] between the client and the resource server. If TLS
234234
traffic needs to be terminated at an intermediary, refer to
235235
(#tls_terminating) for further security advice.
236236

A04_attacks-and-mitigations.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -902,7 +902,8 @@ specific security measures, as described in the respective sections.
902902
However, in some cases, these measures are not sufficient or are not
903903
implemented correctly. Authorization servers therefore SHOULD ensure that
904904
access tokens are sender-constrained and audience-restricted as described
905-
in the following.
905+
in the following. Architecture and performance reasons may
906+
prevent the use of these measures in some deployments.
906907

907908

908909
### Sender-Constrained Access Tokens {#pop_tokens}
@@ -1451,8 +1452,8 @@ inadvertently be sent to malicious origins or injected from malicious origins.
14511452

14521453
### Examples
14531454

1454-
The following JavaScript examples of attacks using in-browser communication are
1455-
described in [@research.rub]:
1455+
The following non-normative pseudocode examples of attacks using in-browser
1456+
communication are described in [@research.rub]:
14561457

14571458
#### Insufficient Limitation of Receiver Origins
14581459

@@ -1512,7 +1513,7 @@ generally required.
15121513
When comparing client receiver origins against pre-registered origins,
15131514
authorization servers MUST utilize exact string matching as described in
15141515
(#iuv_countermeasures). Authorization servers MUST send postMessages to
1515-
trusted client receiver origins:
1516+
trusted client receiver origins, as shown in the following, non-normative example:
15161517

15171518
```
15181519
window.opener.postMessage(
@@ -1532,7 +1533,7 @@ access tokens (see (#insufficient_uri_validation)).
15321533
Clients MUST prevent injection of in-browser messages on the client
15331534
receiver endpoint. Clients MUST utilize exact string matching to compare
15341535
the initiator origin of an in-browser message with the authorization
1535-
server origin:
1536+
server origin, as shown in the following, non-normative example:
15361537

15371538
```
15381539
window.addEventListener("message", (e) => {

B_references.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,3 +278,13 @@
278278
<date day="20" month="December" year="2020"/>
279279
</front>
280280
</reference>
281+
282+
283+
<reference anchor="BCP195" target="https://www.rfc-editor.org/info/bcp195">
284+
<front>
285+
<title>BCP195</title>
286+
<author>
287+
<organization>IETF</organization>
288+
</author>
289+
</front>
290+
</reference>

0 commit comments

Comments
 (0)