Skip to content

Commit e0f411f

Browse files
authored
Merge pull request #96 from oauthstuff/danielfett/ms-feedback
Microsoft feedback
2 parents 6f1a4e7 + 3c151a5 commit e0f411f

File tree

4 files changed

+23
-6
lines changed

4 files changed

+23
-6
lines changed

A02_recommendations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ access token replay as described in (#insufficient_uri_validation),
110110
(#credential_leakage_referrer), (#browser_history), and
111111
(#access_token_injection).
112112

113-
Moreover, no viable method for sender-constraining exists to
113+
Moreover, no standardized method for sender-constraining exists to
114114
bind access tokens to a specific client (as recommended in
115115
(#token_replay_prevention)) when the access tokens are issued in the
116116
authorization response. This means that an attacker can use the leaked or stolen

A04_attacks-and-mitigations.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ The attack described above works for the implicit grant as well. If
106106
the attacker is able to send the authorization response to an attacker-controlled URI, the attacker will directly get access to the fragment carrying the
107107
access token.
108108

109-
Additionally, implicit clients can be subject to a further kind of
109+
Additionally, implicit grants (and also other grants when using `response_mode=fragment` as defined in [@OAuth.Responses]) can be subject to a further kind of
110110
attack. It utilizes the fact that user agents re-attach fragments to
111111
the destination URL of a redirect if the location header does not
112112
contain a fragment (see [@!RFC9110], Section 17.11). The attack
@@ -211,8 +211,7 @@ from the authorization server's or the client's website, respectively. Most
211211
importantly, authorization codes or `state` values can be disclosed in
212212
this way. Although specified otherwise in [@RFC9110], Section 10.1.3,
213213
the same may happen to access tokens conveyed in URI fragments due to
214-
browser implementation issues, as illustrated by Chromium Issue 168213
215-
[@bug.chromium].
214+
browser implementation issues, as illustrated by a (now fixed) issue in the Chromium project [@bug.chromium].
216215

217216
### Leakage from the OAuth Client
218217

B_references.md

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,24 @@
5353
</front>
5454
</reference>
5555

56-
56+
<reference anchor="OAuth.Responses" target="https://openid.net/specs/oauth-v2-multiple-response-types-1_0.html">
57+
<front>
58+
<title>OAuth 2.0 Multiple Response Type Encoding Practices</title>
59+
<author initials="B." surname="de Medeiros" fullname="Breno de Medeiros">
60+
<organization>Google</organization>
61+
</author>
62+
<author initials="M." surname="Scurtescu" fullname="Mihai Scurtescu">
63+
<organization>Google</organization>
64+
</author>
65+
<author initals="P." surname="Tarjan" fullname="Peter Tarjan">
66+
<organization>Facebook</organization>
67+
</author>
68+
<author initials="M." surname="Jones" fullname="Mike Jones">
69+
<organization>Microsoft</organization>
70+
</author>
71+
<date day="25" month="Feb" year="2014"/>
72+
</front>
73+
</reference>
5774

5875
<reference anchor="owasp.redir" target="https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html">
5976
<front>
@@ -190,7 +207,7 @@
190207
<format target="https://www.doc.ic.ac.uk/~maffeis/papers/jcs14.pdf" type="pdf" />
191208
</reference>
192209

193-
<reference anchor="bug.chromium" target="https://bugs.chromium.org/p/chromium/issues/detail?id=168213/">
210+
<reference anchor="bug.chromium" target="https://issues.chromium.org/issues/40076763/">
194211
<front>
195212
<title>Referer header includes URL fragment when opening link using New Tab</title>
196213
<author></author>

C_documenthistory.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
-27
66

7+
* Mostly editorial feedback from Microsoft incorporated
78
* Feedback from SECDIR review incorporated
89

910
-26

0 commit comments

Comments
 (0)