Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline to import version. #145

Open
dosumis opened this issue Jul 15, 2021 · 4 comments
Open

Update pipeline to import version. #145

dosumis opened this issue Jul 15, 2021 · 4 comments
Assignees

Comments

@dosumis
Copy link
Contributor

dosumis commented Jul 15, 2021

Dummy ticket for tracking this issue on ZenHub: https://github.com/orgs/VirtualFlyBrain/projects/2#card-65049072

@hkir-dev
Copy link
Contributor

hkir-dev commented Jul 26, 2021

In the triplestore we only have the version of the BDS ontology. We don't have version info for imported ontologies and terms.

We need to handle this in the BDS makefile. While building import modules (sub ontologies), we can add "owl:versionInfo" "yyyy-mm-dd" to imported terms with robot query.
This info will be automatically rolled to the triplestore and noe4j.

Decisions to make @dosumis:

  • Some classes are imported from multiple sources. For example, http://purl.obolibrary.org/obo/BFO_0000002 exists in bfo_import, cl, pato and uberon. Similarly, CL_0000738 defined in both CL and uberon. These are having multiple versions and we cannot decide which version is coming from which source with single owl:versionInfo datatype property. Should we use full version iri, or another string format?

@hkir-dev
Copy link
Contributor

hkir-dev commented Sep 1, 2021

Related: ontodev/robot#893

@hkir-dev
Copy link
Contributor

hkir-dev commented Sep 1, 2021

While robot development is ongoing, as a short term workaround; We can inject version info to the entities while generating import modules (imports/%_import.owl) in the pipeline.

@hkir-dev
Copy link
Contributor

hkir-dev commented Sep 2, 2021

Ontology metadata (version & title) imported to the neo4j (handled in the vfb_pipeline_dumps). Also we have an "Ontology" node label to quickly access the source ontology metadata.
image

Also added imported (CL, uberon, pato etc.) concepts' version info to the neo4j (handled in the bds makefile).
image

Intentionally didn't added version info to the import of imports. For example, entities from BFO domain are coming from other ontologies (cl, pato, uberon etc.) BFO->CL->BDS. I didn't added version info to those to keep simplicity. But if required, it can be easily added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants