Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2646 NTR-lung resident granzyme k-associated CD8 T cell #2648

Merged

Conversation

Caroline-99
Copy link
Collaborator

@Caroline-99 Caroline-99 commented Oct 14, 2024

Fixes #2646 #2677

  • Added a new term with textual and logical defs, synonyms and refs
  • Imported a PRO term

- Added a new term with textual and logical defs, synonyms and refs
- Imported a PRO term
@Caroline-99 Caroline-99 linked an issue Oct 14, 2024 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Oct 14, 2024
@Caroline-99 Caroline-99 changed the title Fixes #2646 lung resident granzyme k-associated CD8 T cell Fixes #2646 NTR-lung resident granzyme k-associated CD8 T cell Oct 14, 2024
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments. There are different suggestions that we can discuss.

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@Caroline-99 Caroline-99 linked an issue Oct 18, 2024 that may be closed by this pull request
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-10-18/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-10-18/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

cycling B cell http://purl.obolibrary.org/obo/CL_4033068

Removed

cycling CD4-positive, alpha-beta T cell http://purl.obolibrary.org/obo/CL_4033075

Removed

cycling CD8-positive, alpha-beta T cell http://purl.obolibrary.org/obo/CL_4033074

Removed

cycling T cell http://purl.obolibrary.org/obo/CL_4033069

Removed

cycling alveolar macrophage http://purl.obolibrary.org/obo/CL_4033077

Removed

cycling basal cell http://purl.obolibrary.org/obo/CL_4033082

Removed

cycling dendritic cell http://purl.obolibrary.org/obo/CL_4033070

Removed

cycling endothelial cell of lymphatic vessel http://purl.obolibrary.org/obo/CL_4033079

Removed

cycling gamma-delta T cell http://purl.obolibrary.org/obo/CL_4033072

Removed

cycling glial cell http://purl.obolibrary.org/obo/CL_4047002

Removed

cycling macrophage http://purl.obolibrary.org/obo/CL_4033076

Removed

cycling monocyte http://purl.obolibrary.org/obo/CL_4033073

Removed

cycling mononuclear phagocyte http://purl.obolibrary.org/obo/CL_4033078

Removed

cycling myeloid cell http://purl.obolibrary.org/obo/CL_4033081

Removed

cycling natural killer cell http://purl.obolibrary.org/obo/CL_4033071

Removed

cycling neuroblast (sensu Vertebrata) http://purl.obolibrary.org/obo/CL_4047005

Removed

cycling plasma cell http://purl.obolibrary.org/obo/CL_4047003

Removed

cycling pulmonary alveolar type 2 cell http://purl.obolibrary.org/obo/CL_4033080

Removed

cycling stromal cell http://purl.obolibrary.org/obo/CL_4047001

Removed

cycling type EC enteroendocrine cell http://purl.obolibrary.org/obo/CL_4047004

Removed

granzyme K-associated CD8 T cell http://purl.obolibrary.org/obo/CL_4052021

Added

lung resident granzyme K-associated CD8 T cell http://purl.obolibrary.org/obo/CL_4052020

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

granzyme K http://purl.obolibrary.org/obo/PR_000003472

Added

granzyme K-associated CD8 T cell http://purl.obolibrary.org/obo/CL_4052021

Added

lung resident granzyme K-associated CD8 T cell http://purl.obolibrary.org/obo/CL_4052020

Added

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the previous comments and add the new cell type

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edits look fine.
NOTE: The contributors for cycling cells (added by DOSDP) are removed unintentionally.

@Caroline-99 Caroline-99 merged commit 97b94e6 into master Oct 21, 2024
1 check passed
@Caroline-99 Caroline-99 deleted the 2646-lung-resident-granzyme-k-associated-cd8-t-cell branch October 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] granzyme K-associated CD8 T cell Lung-resident Granzyme K-associated CD8 T cell
2 participants