-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Trigger expansion from a 3rd party tool #136
Comments
Hi there, this sounds great! Building in a proper API function to Unfurl has been on my list for a while, but there were a few issues (I haven't built one before and I wasn't sure what requirements a consumer of the API would have). If you wanted to build the API part, that'd be awesome and I'd be happy to help however I can. There's an existing As for JSON output, getting JSON isn't hard (it's used internally and there's already a |
Great, I'll have a go at it in the coming days, probably next week. |
I started to play with the app, but I have a quick question before I do so: the public instance expects links that look like that: The URL to expand in the public instance is a parameter ( (sorry, editing this message as I look at the code) an URL like that:
The reason it works right now is because you use the referrer to extract the URL to expand. I understand it makes things easier to copy/paste a URL, but would you consider requiring an url encoded parameter instead? |
okay, so here is a small PR, I figured out a way to keep the current approach to submit a URL without requiring quoting it first. Please let me know what you think and if you're ok with that, I'll implement the non-visjs API part. |
My initial idea for Unfurl was for the user to be able to be on a site, then insert For the public instance, it's powered by GCP cloud functions, so I actually base64 encode the I hope this at least explains why it is like it is. I'm happy to make changes to support the new API and make things more streamlined. |
I think the PR looks good 👍 |
Great, thanks for the feedback, I'll keep working on it in this direction |
I'm one of the core dev of lookyloo and I'd love not to reinvent the wheel when it gets to expanding URLs, and unfurl pretty much does exactly that. So I'd love to have a way to push URLs to a unfurl instance from lookyloo, get the expanded information (preferably in JSON, but I can work with CSV), displaying what makes sense to display on lookyloo (that part needs to be defined), and allowing the lookyloo users to click on a link to see the unfurl representation on an unfurl instance.
As a lookyloo capture often has a few hundred URLs, the submissions should be as automated as possible. For that, we need a way to trigger a submission to an existing unfurl instance, and as far as I can tell, it is not supported yet.
From the top of my mind, we need to following:
It's a bit of a long shot, but please let me know if that's something you'd be interested in the tool? If yes, I'll be happy to implement the REST API and the python lib/client that talks to it.
The text was updated successfully, but these errors were encountered: