Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakePresets.json should have a single definition for ENABLE_FRONTEND_API and ENABLE_QT #103

Closed
Susko3 opened this issue Nov 22, 2023 · 2 comments · Fixed by #111
Closed

Comments

@Susko3
Copy link
Contributor

Susko3 commented Nov 22, 2023

Operating System Info

Windows 11

Expected Behavior

I should be able to change the values of ENABLE_FRONTEND_API and ENABLE_QT in one place and have them apply to all operating systems.

Current Behavior

I have to change ENABLE_FRONTEND_API and/or ENABLE_QT on each OS I support.

Steps to Reproduce

  1. Use this template
  2. In your plugin, make us of QT or the OBS frontend api
    • this requires setting the appropriate build variables, so you:
  3. Open CMakePresets.json and quickly realise you need to set the same value multiple times, leading to possible user-errors

Anything else we should know?

Using inheritance and a single preset for the two cross-platform variables makes sense as a solution.

Susko3 added a commit to Susko3/obs-hide-desktop-icons-while-streaming that referenced this issue Nov 22, 2023
@PatTheMav
Copy link
Member

As you already mentioned the appropriate fix for the issue (create a hidden "template" preset with global values), would you be willing to open a PR to fix this accordingly?

@Susko3
Copy link
Contributor Author

Susko3 commented Dec 11, 2023

I'm not too familiar with cmake presets, and there are currently a bunch of configurations for different operating systems. So I don't feel confident about changing things.

I was hoping someone with more experience would pick up my idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants