Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created release does not use plugin name #105

Closed
CodeYan01 opened this issue Nov 29, 2023 · 4 comments · Fixed by #109
Closed

Created release does not use plugin name #105

CodeYan01 opened this issue Nov 29, 2023 · 4 comments · Fixed by #109

Comments

@CodeYan01
Copy link

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

30.0.0

OBS Studio Version (Other)

No response

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

Have the plugin name in the release title

Current Behavior

image

Creates a draft release titled OBS Studio. While it's fine because it is a draft, having a friendly name in buildspec.json would be great so that we don't have to change the title all the time. I already put 'media-playlist-source' as the name but being able to put 'Media Playlist Source' in release titles automatically would be useful.

Steps to Reproduce

  1. Push a tag to make a release
  2. Check the draft release

Anything else we should know?

No response

@PatTheMav
Copy link
Member

@CodeYan01 please check with the changes added by #109.

@CodeYan01
Copy link
Author

Thanks, will report back when I get to it soon

@CodeYan01
Copy link
Author

@PatTheMav
image

Yes, it did use the plugin name in the release. But I think it would be great if we could specify a "pretty-name" in the buildspec that it will use in the release title and installer. Like for this one, I would prefer to see "Media Playlist Source" (title case and no dashes).

@PatTheMav
Copy link
Member

@CodeYan01 good point, I updated the PR - the buildspec now contains a key displayName that can be used for this and the old name will be used as a fallback if the former is not set. Also allowed me to make the regular expression more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants