Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libobs: Export SIMDe headers unconditionally for plugin development #9762

Merged
merged 1 commit into from
Oct 26, 2023
Merged

libobs: Export SIMDe headers unconditionally for plugin development #9762

merged 1 commit into from
Oct 26, 2023

Conversation

PatTheMav
Copy link
Member

Description

Changes libobs export to include SIMDe headers by default.

Motivation and Context

Fixes obsproject/obs-plugintemplate#95.

How Has This Been Tested?

Checked import of libobs Framework with new settings and confirmed SIMDe headers were correctly copied over.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@PatTheMav PatTheMav added the Bug Fix Non-breaking change which fixes an issue label Oct 26, 2023
@RytoEX RytoEX requested a review from gxalpha October 26, 2023 21:23
RytoEX
RytoEX approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine at a glance if we want to always export these.

@PatTheMav
Copy link
Member Author

Seems fine at a glance if we want to always export these.

Shouldn't hurt because headers are only actually pulled in by preprocessors if required, but we enable SIMD for clang and gcc by default because it will just fall back on native vector operations on x86_64 anyway (so there's no harm in enabling it by default and also using SIMDe by default).

@RytoEX RytoEX added this to the OBS Studio 30.0 milestone Oct 26, 2023
@RytoEX RytoEX merged commit ff2a706 into obsproject:master Oct 26, 2023
@PatTheMav PatTheMav deleted the libobs-simde-export branch October 26, 2023 22:23
@gxalpha gxalpha mentioned this pull request Oct 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

@gxalpha gxalpha Awaiting requested review from gxalpha

Assignees
No one assigned
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Milestone
OBS Studio 30.0
Development

Successfully merging this pull request may close these issues.

macos github action fails with "sse2.h is missing" when used with obs 30.0.0-rc1
2 participants
@PatTheMav @RytoEX