frontend,shared: Replace and disable contextless connect calls

gxalpha · gxalpha · commit a13ee9108229 · 2025-08-31T19:20:31.000+02:00
diff --git a/frontend/OBSApp.cpp b/frontend/OBSApp.cpp
@@ -1220,7 +1220,7 @@ bool OBSApp::OBSInit()
 
 	mainWindow->OBSInit();
 
-	connect(this, &QGuiApplication::applicationStateChanged,
+	connect(this, &QGuiApplication::applicationStateChanged, this,
 		[this](Qt::ApplicationState state) { ResetHotkeyState(state == Qt::ApplicationActive); });
 	ResetHotkeyState(applicationState() == Qt::ApplicationActive);
 
diff --git a/frontend/OBSStudioAPI.cpp b/frontend/OBSStudioAPI.cpp
@@ -326,7 +326,7 @@ void OBSStudioAPI::obs_frontend_add_tools_menu_item(const char *name, obs_fronte
 
 	QAction *action = main->ui->menuTools->addAction(QT_UTF8(name));
 	action->setMenuRole(QAction::NoRole);
-	QObject::connect(action, &QAction::triggered, func);
+	QObject::connect(action, &QAction::triggered, action, func);
 }
 
 bool OBSStudioAPI::obs_frontend_add_dock_by_id(const char *id, const char *title, void *widget)
diff --git a/frontend/components/OBSAdvAudioCtrl.cpp b/frontend/components/OBSAdvAudioCtrl.cpp
@@ -207,7 +207,8 @@ OBSAdvAudioCtrl::OBSAdvAudioCtrl(QGridLayout *, obs_source_t *source_) : source(
 		connect(monitoringType, &QComboBox::currentIndexChanged, this, &OBSAdvAudioCtrl::monitoringTypeChanged);
 
 	auto connectMixer = [this](QCheckBox *mixer, int num) {
-		connect(mixer, &QCheckBox::clicked, [this, num](bool checked) { setMixer(source, num, checked); });
+		connect(mixer, &QCheckBox::clicked, this,
+			[this, num](bool checked) { setMixer(source, num, checked); });
 	};
 	connectMixer(mixer1, 0);
 	connectMixer(mixer2, 1);
diff --git a/frontend/components/SourceTreeItem.cpp b/frontend/components/SourceTreeItem.cpp
@@ -151,8 +151,8 @@ SourceTreeItem::SourceTreeItem(SourceTree *tree_, OBSSceneItem sceneitem_) : tre
 		obs_sceneitem_set_locked(sceneitem, checked);
 	};
 
-	connect(vis, &QAbstractButton::clicked, setItemVisible);
-	connect(lock, &QAbstractButton::clicked, setItemLocked);
+	connect(vis, &QAbstractButton::clicked, this, setItemVisible);
+	connect(lock, &QAbstractButton::clicked, this, setItemLocked);
 }
 
 void SourceTreeItem::paintEvent(QPaintEvent *event)
diff --git a/frontend/components/VisibilityItemWidget.cpp b/frontend/components/VisibilityItemWidget.cpp
@@ -28,7 +28,7 @@ VisibilityItemWidget::VisibilityItemWidget(obs_source_t *source_)
 
 	setLayout(itemLayout);
 
-	connect(vis, &QCheckBox::clicked, [this](bool visible) { obs_source_set_enabled(source, visible); });
+	connect(vis, &QCheckBox::clicked, this, [this](bool visible) { obs_source_set_enabled(source, visible); });
 }
 
 void VisibilityItemWidget::OBSSourceEnabled(void *param, calldata_t *data)
diff --git a/frontend/dialogs/OBSBasicFilters.cpp b/frontend/dialogs/OBSBasicFilters.cpp
@@ -76,10 +76,10 @@ OBSBasicFilters::OBSBasicFilters(QWidget *parent, OBSSource source_)
 
 	installEventFilter(CreateShortcutFilter());
 
-	connect(ui->asyncFilters->itemDelegate(), &QAbstractItemDelegate::closeEditor,
+	connect(ui->asyncFilters->itemDelegate(), &QAbstractItemDelegate::closeEditor, this,
 		[this](QWidget *editor) { FilterNameEdited(editor, ui->asyncFilters); });
 
-	connect(ui->effectFilters->itemDelegate(), &QAbstractItemDelegate::closeEditor,
+	connect(ui->effectFilters->itemDelegate(), &QAbstractItemDelegate::closeEditor, this,
 		[this](QWidget *editor) { FilterNameEdited(editor, ui->effectFilters); });
 
 	QPushButton *close = ui->buttonBox->button(QDialogButtonBox::Close);
@@ -133,7 +133,7 @@ OBSBasicFilters::OBSBasicFilters(QWidget *parent, OBSSource source_)
 		ui->rightLayout->setContentsMargins(0, 0, 0, 0);
 		ui->preview->show();
 		if (drawable_type)
-			connect(ui->preview, &OBSQTDisplay::DisplayCreated, addDrawCallback);
+			connect(ui->preview, &OBSQTDisplay::DisplayCreated, this, addDrawCallback);
 	} else {
 		ui->rightLayout->setContentsMargins(0, noPreviewMargin, 0, 0);
 		ui->preview->hide();
@@ -486,7 +486,7 @@ QMenu *OBSBasicFilters::CreateAddFilterPopupMenu(bool async)
 
 		QAction *popupItem = new QAction(QT_UTF8(type.name.c_str()), this);
 		popupItem->setData(QT_UTF8(type.type.c_str()));
-		connect(popupItem, &QAction::triggered, [this, type]() { AddNewFilter(type.type.c_str()); });
+		connect(popupItem, &QAction::triggered, this, [this, type]() { AddNewFilter(type.type.c_str()); });
 		popup->addAction(popupItem);
 
 		foundValues = true;
diff --git a/frontend/dialogs/OBSBasicInteraction.cpp b/frontend/dialogs/OBSBasicInteraction.cpp
@@ -69,7 +69,7 @@ OBSBasicInteraction::OBSBasicInteraction(QWidget *parent, OBSSource source_)
 		obs_display_add_draw_callback(ui->preview->GetDisplay(), OBSBasicInteraction::DrawPreview, this);
 	};
 
-	connect(ui->preview, &OBSQTDisplay::DisplayCreated, addDrawCallback);
+	connect(ui->preview, &OBSQTDisplay::DisplayCreated, this, addDrawCallback);
 }
 
 OBSBasicInteraction::~OBSBasicInteraction()
diff --git a/frontend/dialogs/OBSBasicProperties.cpp b/frontend/dialogs/OBSBasicProperties.cpp
@@ -103,7 +103,7 @@ OBSBasicProperties::OBSBasicProperties(QWidget *parent, OBSSource source_)
 
 	if (drawable_preview && drawable_type) {
 		ui->preview->show();
-		connect(ui->preview, &OBSQTDisplay::DisplayCreated, addDrawCallback);
+		connect(ui->preview, &OBSQTDisplay::DisplayCreated, this, addDrawCallback);
 
 	} else if (type == OBS_SOURCE_TYPE_TRANSITION) {
 		sourceA = obs_source_create_private("scene", "sourceA", nullptr);
@@ -139,10 +139,10 @@ OBSBasicProperties::OBSBasicProperties(QWidget *parent, OBSSource source_)
 			direction = true;
 		};
 
-		connect(view, &OBSPropertiesView::Changed, updateCallback);
+		connect(view, &OBSPropertiesView::Changed, this, updateCallback);
 
 		ui->preview->show();
-		connect(ui->preview, &OBSQTDisplay::DisplayCreated, addTransitionDrawCallback);
+		connect(ui->preview, &OBSQTDisplay::DisplayCreated, this, addTransitionDrawCallback);
 
 	} else {
 		ui->preview->hide();
@@ -187,7 +187,7 @@ void OBSBasicProperties::AddPreviewButton()
 		end = nullptr;
 	};
 
-	connect(playButton, &QPushButton::clicked, play);
+	connect(playButton, &QPushButton::clicked, this, play);
 }
 
 static obs_source_t *CreateLabel(const char *name, size_t h)
diff --git a/frontend/dialogs/OBSBasicSourceSelect.cpp b/frontend/dialogs/OBSBasicSourceSelect.cpp
@@ -359,18 +359,18 @@ OBSBasicSourceSelect::OBSBasicSourceSelect(OBSBasic *parent, const char *id_, un
 
 	installEventFilter(CreateShortcutFilter());
 
-	connect(ui->createNew, &QRadioButton::pressed, [&]() {
+	connect(ui->createNew, &QRadioButton::pressed, this, [&]() {
 		QPushButton *button = ui->buttonBox->button(QDialogButtonBox::Ok);
 		if (!button->isEnabled())
 			button->setEnabled(true);
 	});
-	connect(ui->selectExisting, &QRadioButton::pressed, [&]() {
+	connect(ui->selectExisting, &QRadioButton::pressed, this, [&]() {
 		QPushButton *button = ui->buttonBox->button(QDialogButtonBox::Ok);
 		bool enabled = ui->sourceList->selectedItems().size() != 0;
 		if (button->isEnabled() != enabled)
 			button->setEnabled(enabled);
 	});
-	connect(ui->sourceList, &QListWidget::itemSelectionChanged, [&]() {
+	connect(ui->sourceList, &QListWidget::itemSelectionChanged, this, [&]() {
 		QPushButton *button = ui->buttonBox->button(QDialogButtonBox::Ok);
 		if (!button->isEnabled())
 			button->setEnabled(true);
diff --git a/frontend/importer/ImporterEntryPathItemDelegate.cpp b/frontend/importer/ImporterEntryPathItemDelegate.cpp
@@ -68,7 +68,7 @@ QWidget *ImporterEntryPathItemDelegate::createEditor(QWidget *parent, const QSty
 	browseButton->setSizePolicy(buttonSizePolicy);
 	layout->addWidget(browseButton);
 
-	container->connect(browseButton, &QToolButton::clicked, browseCallback);
+	connect(browseButton, &QToolButton::clicked, this, browseCallback);
 
 	// The "clear" button is not shown in output cells
 	// or the insertion point's input cell.
@@ -78,7 +78,7 @@ QWidget *ImporterEntryPathItemDelegate::createEditor(QWidget *parent, const QSty
 		clearButton->setSizePolicy(buttonSizePolicy);
 		layout->addWidget(clearButton);
 
-		container->connect(clearButton, &QToolButton::clicked, clearCallback);
+		connect(clearButton, &QToolButton::clicked, this, clearCallback);
 	}
 
 	container->setLayout(layout);
diff --git a/frontend/plugins/aja-output-ui/aja-ui-main.cpp b/frontend/plugins/aja-output-ui/aja-ui-main.cpp
@@ -374,7 +374,7 @@ void addOutputUI(void)
 		ajaOutputUI->ShowHideDialog();
 	};
 
-	action->connect(action, &QAction::triggered, cb);
+	QObject::connect(action, &QAction::triggered, action, cb);
 }
 
 static void OBSEvent(enum obs_frontend_event event, void *)
diff --git a/frontend/plugins/decklink-captions/decklink-captions.cpp b/frontend/plugins/decklink-captions/decklink-captions.cpp
@@ -133,7 +133,7 @@ void addOutputUI(void)
 
 	obs_frontend_add_save_callback(save_decklink_caption_data, nullptr);
 
-	action->connect(action, &QAction::triggered, cb);
+	QObject::connect(action, &QAction::triggered, action, cb);
 }
 
 bool obs_module_load(void)
diff --git a/frontend/plugins/decklink-output-ui/decklink-ui-main.cpp b/frontend/plugins/decklink-output-ui/decklink-ui-main.cpp
@@ -427,7 +427,7 @@ void addOutputUI(void)
 		doUI->ShowHideDialog();
 	};
 
-	action->connect(action, &QAction::triggered, cb);
+	QObject::connect(action, &QAction::triggered, action, cb);
 }
 
 static void OBSEvent(enum obs_frontend_event event, void *)
diff --git a/frontend/plugins/frontend-tools/auto-scene-switcher.cpp b/frontend/plugins/frontend-tools/auto-scene-switcher.cpp
@@ -503,5 +503,5 @@ extern "C" void InitSceneSwitcher()
 	obs_frontend_add_save_callback(SaveSceneSwitcher, nullptr);
 	obs_frontend_add_event_callback(OBSEvent, nullptr);
 
-	action->connect(action, &QAction::triggered, cb);
+	QObject::connect(action, &QAction::triggered, action, cb);
 }
diff --git a/frontend/plugins/frontend-tools/output-timer.cpp b/frontend/plugins/frontend-tools/output-timer.cpp
@@ -315,5 +315,5 @@ extern "C" void InitOutputTimer()
 	obs_frontend_add_save_callback(SaveOutputTimer, nullptr);
 	obs_frontend_add_event_callback(OBSEvent, nullptr);
 
-	action->connect(action, &QAction::triggered, cb);
+	QObject::connect(action, &QAction::triggered, action, cb);
 }
diff --git a/frontend/plugins/frontend-tools/scripts.cpp b/frontend/plugins/frontend-tools/scripts.cpp
@@ -677,5 +677,5 @@ extern "C" void InitScripts()
 	obs_frontend_add_preload_callback(load_script_data, nullptr);
 	obs_frontend_add_event_callback(obs_event, nullptr);
 
-	action->connect(action, &QAction::triggered, cb);
+	QObject::connect(action, &QAction::triggered, action, cb);
 }
diff --git a/frontend/settings/OBSBasicSettings.cpp b/frontend/settings/OBSBasicSettings.cpp
@@ -2389,9 +2389,9 @@ void OBSBasicSettings::LoadAudioSources()
 		TruncateLabel(label, label->text());
 		label->setMinimumSize(QSize(170, 0));
 		label->setAlignment(Qt::AlignRight | Qt::AlignTrailing | Qt::AlignVCenter);
-		connect(label, &OBSSourceLabel::Removed,
+		connect(label, &OBSSourceLabel::Removed, this,
 			[=]() { QMetaObject::invokeMethod(this, "ReloadAudioSources"); });
-		connect(label, &OBSSourceLabel::Destroyed,
+		connect(label, &OBSSourceLabel::Destroyed, this,
 			[=]() { QMetaObject::invokeMethod(this, "ReloadAudioSources"); });
 
 		layout->addRow(label, form);
@@ -2824,7 +2824,7 @@ void OBSBasicSettings::LoadHotkeySettings(obs_hotkey_id ignoreKey)
 			HotkeysChanged();
 			ScanDuplicateHotkeys(hotkeysLayout);
 		});
-		connect(hw, &OBSHotkeyWidget::SearchKey, [=](obs_key_combination_t combo) {
+		connect(hw, &OBSHotkeyWidget::SearchKey, this, [=](obs_key_combination_t combo) {
 			ui->hotkeyFilterSearch->setText("");
 			ui->hotkeyFilterInput->HandleNewKey(combo);
 			ui->hotkeyFilterInput->KeyChanged(combo);
diff --git a/frontend/settings/OBSHotkeyEdit.cpp b/frontend/settings/OBSHotkeyEdit.cpp
@@ -207,7 +207,7 @@ void OBSHotkeyEdit::CreateDupeIcon()
 {
 	dupeIcon = addAction(settings->GetHotkeyConflictIcon(), ActionPosition::TrailingPosition);
 	dupeIcon->setToolTip(QTStr("Basic.Settings.Hotkeys.DuplicateWarning"));
-	QObject::connect(dupeIcon, &QAction::triggered, [=] { emit SearchKey(key); });
+	QObject::connect(dupeIcon, &QAction::triggered, this, [=] { emit SearchKey(key); });
 	dupeIcon->setVisible(false);
 }
 
diff --git a/frontend/settings/OBSHotkeyWidget.cpp b/frontend/settings/OBSHotkeyWidget.cpp
@@ -98,7 +98,7 @@ void OBSHotkeyWidget::AddEdit(obs_key_combination combo, int idx)
 	clear->setToolTip(QTStr("Clear"));
 	clear->setEnabled(!obs_key_combination_is_empty(combo));
 
-	QObject::connect(edit, &OBSHotkeyEdit::KeyChanged, [=](obs_key_combination_t new_combo) {
+	QObject::connect(edit, &OBSHotkeyEdit::KeyChanged, this, [=](obs_key_combination_t new_combo) {
 		clear->setEnabled(!obs_key_combination_is_empty(new_combo));
 		revert->setEnabled(edit->original != new_combo);
 	});
@@ -117,10 +117,10 @@ void OBSHotkeyWidget::AddEdit(obs_key_combination combo, int idx)
 		return std::distance(begin(removeButtons), res);
 	};
 
-	QObject::connect(add, &QPushButton::clicked,
+	QObject::connect(add, &QPushButton::clicked, this,
 			 [&, CurrentIndex] { AddEdit({0, OBS_KEY_NONE}, CurrentIndex() + 1); });
 
-	QObject::connect(remove, &QPushButton::clicked, [&, CurrentIndex] { RemoveEdit(CurrentIndex()); });
+	QObject::connect(remove, &QPushButton::clicked, this, [&, CurrentIndex] { RemoveEdit(CurrentIndex()); });
 
 	QHBoxLayout *subLayout = new QHBoxLayout;
 	subLayout->setContentsMargins(0, 2, 0, 2);
@@ -148,8 +148,9 @@ void OBSHotkeyWidget::AddEdit(obs_key_combination combo, int idx)
 	QObject::connect(revert, &QPushButton::clicked, edit, &OBSHotkeyEdit::ResetKey);
 	QObject::connect(clear, &QPushButton::clicked, edit, &OBSHotkeyEdit::ClearKey);
 
-	QObject::connect(edit, &OBSHotkeyEdit::KeyChanged, [&](obs_key_combination) { emit KeyChanged(); });
-	QObject::connect(edit, &OBSHotkeyEdit::SearchKey, [=](obs_key_combination combo) { emit SearchKey(combo); });
+	QObject::connect(edit, &OBSHotkeyEdit::KeyChanged, this, [&](obs_key_combination) { emit KeyChanged(); });
+	QObject::connect(edit, &OBSHotkeyEdit::SearchKey, this,
+			 [=](obs_key_combination combo) { emit SearchKey(combo); });
 }
 
 void OBSHotkeyWidget::RemoveEdit(size_t idx, bool signal)
diff --git a/frontend/utility/MissingFilesPathItemDelegate.cpp b/frontend/utility/MissingFilesPathItemDelegate.cpp
@@ -61,7 +61,7 @@ QWidget *MissingFilesPathItemDelegate::createEditor(QWidget *parent, const QStyl
 	browseButton->setSizePolicy(buttonSizePolicy);
 	layout->addWidget(browseButton);
 
-	container->connect(browseButton, &QToolButton::clicked, browseCallback);
+	connect(browseButton, &QToolButton::clicked, this, browseCallback);
 
 	QToolButton *clearButton = new QToolButton();
 	QIcon icon;
@@ -71,7 +71,7 @@ QWidget *MissingFilesPathItemDelegate::createEditor(QWidget *parent, const QStyl
 	clearButton->setSizePolicy(buttonSizePolicy);
 	layout->addWidget(clearButton);
 
-	container->connect(clearButton, &QToolButton::clicked, clearCallback);
+	connect(clearButton, &QToolButton::clicked, this, clearCallback);
 
 	container->setLayout(layout);
 	container->setFocusProxy(text);
diff --git a/frontend/utility/RemuxEntryPathItemDelegate.cpp b/frontend/utility/RemuxEntryPathItemDelegate.cpp
@@ -85,7 +85,7 @@ QWidget *RemuxEntryPathItemDelegate::createEditor(QWidget *parent, const QStyleO
 		browseButton->setSizePolicy(buttonSizePolicy);
 		layout->addWidget(browseButton);
 
-		container->connect(browseButton, &QToolButton::clicked, browseCallback);
+		connect(browseButton, &QToolButton::clicked, this, browseCallback);
 
 		// The "clear" button is not shown in output cells
 		// or the insertion point's input cell.
@@ -95,7 +95,7 @@ QWidget *RemuxEntryPathItemDelegate::createEditor(QWidget *parent, const QStyleO
 			clearButton->setSizePolicy(buttonSizePolicy);
 			layout->addWidget(clearButton);
 
-			container->connect(clearButton, &QToolButton::clicked, clearCallback);
+			connect(clearButton, &QToolButton::clicked, this, clearCallback);
 		}
 
 		container->setLayout(layout);
diff --git a/frontend/widgets/OBSBasic.cpp b/frontend/widgets/OBSBasic.cpp
@@ -389,8 +389,8 @@ OBSBasic::OBSBasic(QWidget *parent) : OBSMainWindow(parent), undo_s(ui), ui(new
 	};
 	dpi = devicePixelRatioF();
 
-	connect(windowHandle(), &QWindow::screenChanged, displayResize);
-	connect(ui->preview, &OBSQTDisplay::DisplayResized, displayResize);
+	connect(windowHandle(), &QWindow::screenChanged, this, displayResize);
+	connect(ui->preview, &OBSQTDisplay::DisplayResized, this, displayResize);
 
 	/* TODO: Move these into window-basic-preview */
 	/* Preview Scaling label */
@@ -486,7 +486,8 @@ OBSBasic::OBSBasic(QWidget *parent) : OBSMainWindow(parent), undo_s(ui), ui(new
 		nudge->setShortcut(seq);
 		nudge->setShortcutContext(Qt::WidgetShortcut);
 		ui->preview->addAction(nudge);
-		connect(nudge, &QAction::triggered, [this, distance, direction]() { Nudge(distance, direction); });
+		connect(nudge, &QAction::triggered, this,
+			[this, distance, direction]() { Nudge(distance, direction); });
 	};
 
 	addNudge(Qt::Key_Up, MoveDir::Up, 1);
@@ -555,7 +556,8 @@ OBSBasic::OBSBasic(QWidget *parent) : OBSMainWindow(parent), undo_s(ui), ui(new
 	ui->previewDisabledWidget->setContextMenuPolicy(Qt::CustomContextMenu);
 	connect(ui->enablePreviewButton, &QPushButton::clicked, this, &OBSBasic::TogglePreview);
 
-	connect(ui->scenes, &SceneTree::scenesReordered, []() { OBSProjector::UpdateMultiviewProjectors(); });
+	connect(ui->scenes, &SceneTree::scenesReordered, ui->scenes,
+		[]() { OBSProjector::UpdateMultiviewProjectors(); });
 
 	connect(App(), &OBSApp::StyleChanged, this, [this]() { OnEvent(OBS_FRONTEND_EVENT_THEME_CHANGED); });
 
@@ -1142,7 +1144,7 @@ void OBSBasic::OBSInit()
 			ResizePreview(ovi.base_width, ovi.base_height);
 	};
 
-	connect(ui->preview, &OBSQTDisplay::DisplayCreated, addDisplay);
+	connect(ui->preview, &OBSQTDisplay::DisplayCreated, this, addDisplay);
 
 	/* Show the main window, unless the tray icon isn't available
 	 * or neither the setting nor flag for starting minimized is set. */
diff --git a/frontend/widgets/OBSBasicStats.cpp b/frontend/widgets/OBSBasicStats.cpp
@@ -159,8 +159,8 @@ OBSBasicStats::OBSBasicStats(QWidget *parent, bool closable)
 
 	/* --------------------------------------------- */
 	if (closable)
-		connect(closeButton, &QPushButton::clicked, [this]() { close(); });
-	connect(resetButton, &QPushButton::clicked, [this]() { Reset(); });
+		connect(closeButton, &QPushButton::clicked, this, [this]() { close(); });
+	connect(resetButton, &QPushButton::clicked, this, [this]() { Reset(); });
 
 	delete shortcutFilter;
 	shortcutFilter = CreateShortcutFilter();
diff --git a/frontend/widgets/OBSBasic_Docks.cpp b/frontend/widgets/OBSBasic_Docks.cpp
@@ -37,10 +37,10 @@ void setupDockAction(QDockWidget *dock)
 
 	// Replace the slot connected by default
 	QObject::disconnect(action, &QAction::triggered, nullptr, 0);
-	dock->connect(action, &QAction::triggered, newToggleView);
+	QObject::connect(action, &QAction::triggered, dock, newToggleView);
 
 	// Make the action unable to be disabled
-	action->connect(action, &QAction::enabledChanged, neverDisable);
+	QObject::connect(action, &QAction::enabledChanged, action, neverDisable);
 }
 
 void OBSBasic::on_resetDocks_triggered(bool force)
diff --git a/frontend/widgets/OBSBasic_Preview.cpp b/frontend/widgets/OBSBasic_Preview.cpp
@@ -350,7 +350,7 @@ void OBSBasic::Nudge(int dist, MoveDir dir)
 		std::string undo_data(obs_data_get_json(wrapper));
 
 		nudge_timer = new QTimer;
-		QObject::connect(nudge_timer, &QTimer::timeout, [this, &recent_nudge = recent_nudge, undo_data]() {
+		QObject::connect(nudge_timer, &QTimer::timeout, this, [this, &recent_nudge = recent_nudge, undo_data]() {
 			OBSDataAutoRelease rwrapper = obs_scene_save_transform_states(GetCurrentScene(), true);
 			std::string redo_data(obs_data_get_json(rwrapper));
 
@@ -527,9 +527,9 @@ void OBSBasic::ColorChange()
 			QColorDialog *colorDialog = new QColorDialog(this);
 			colorDialog->setOptions(options);
 			colorDialog->setCurrentColor(QColor(customColor));
-			connect(colorDialog, &QColorDialog::currentColorChanged, liveChangeColor);
-			connect(colorDialog, &QColorDialog::colorSelected, changedColor);
-			connect(colorDialog, &QColorDialog::rejected, rejected);
+			connect(colorDialog, &QColorDialog::currentColorChanged, this, liveChangeColor);
+			connect(colorDialog, &QColorDialog::colorSelected, this, changedColor);
+			connect(colorDialog, &QColorDialog::rejected, this, rejected);
 			colorDialog->open();
 		} else {
 			for (int x = 0; x < selectedItems.count(); x++) {
diff --git a/frontend/widgets/OBSBasic_SceneItems.cpp b/frontend/widgets/OBSBasic_SceneItems.cpp
diff --git a/frontend/widgets/OBSBasic_Scenes.cpp b/frontend/widgets/OBSBasic_Scenes.cpp
diff --git a/frontend/widgets/OBSBasic_StudioMode.cpp b/frontend/widgets/OBSBasic_StudioMode.cpp
diff --git a/frontend/widgets/OBSBasic_Transitions.cpp b/frontend/widgets/OBSBasic_Transitions.cpp
diff --git a/frontend/widgets/OBSProjector.cpp b/frontend/widgets/OBSProjector.cpp
diff --git a/frontend/widgets/OBSQTDisplay.cpp b/frontend/widgets/OBSQTDisplay.cpp
diff --git a/frontend/wizards/AutoConfigStreamPage.cpp b/frontend/wizards/AutoConfigStreamPage.cpp
diff --git a/shared/properties-view/double-slider.cpp b/shared/properties-view/double-slider.cpp
diff --git a/shared/properties-view/properties-view.cpp b/shared/properties-view/properties-view.cpp

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ void OBSStudioAPI::obs_frontend_add_tools_menu_item(const char *name, obs_fronte`
`326`	`326`
`327`	`327`	`QAction *action = main->ui->menuTools->addAction(QT_UTF8(name));`
`328`	`328`	`action->setMenuRole(QAction::NoRole);`
`329`		`- QObject::connect(action, &QAction::triggered, func);`
	`329`	`+ QObject::connect(action, &QAction::triggered, action, func);`
`330`	`330`	`}`
`331`	`331`
`332`	`332`	`bool OBSStudioAPI::obs_frontend_add_dock_by_id(const char id, const char title, void *widget)`
Original file line number	Diff line number	Diff line change
`@@ -151,8 +151,8 @@ SourceTreeItem::SourceTreeItem(SourceTree *tree_, OBSSceneItem sceneitem_) : tre`
`151`	`151`	`obs_sceneitem_set_locked(sceneitem, checked);`
`152`	`152`	`};`
`153`	`153`
`154`		`- connect(vis, &QAbstractButton::clicked, setItemVisible);`
`155`		`- connect(lock, &QAbstractButton::clicked, setItemLocked);`
	`154`	`+ connect(vis, &QAbstractButton::clicked, this, setItemVisible);`
	`155`	`+ connect(lock, &QAbstractButton::clicked, this, setItemLocked);`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`void SourceTreeItem::paintEvent(QPaintEvent *event)`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ VisibilityItemWidget::VisibilityItemWidget(obs_source_t *source_)`
`28`	`28`
`29`	`29`	`setLayout(itemLayout);`
`30`	`30`
`31`		`- connect(vis, &QCheckBox::clicked, [this](bool visible) { obs_source_set_enabled(source, visible); });`
	`31`	`+ connect(vis, &QCheckBox::clicked, this, [this](bool visible) { obs_source_set_enabled(source, visible); });`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`void VisibilityItemWidget::OBSSourceEnabled(void param, calldata_t data)`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ OBSBasicInteraction::OBSBasicInteraction(QWidget *parent, OBSSource source_)`
`69`	`69`	`obs_display_add_draw_callback(ui->preview->GetDisplay(), OBSBasicInteraction::DrawPreview, this);`
`70`	`70`	`};`
`71`	`71`
`72`		`- connect(ui->preview, &OBSQTDisplay::DisplayCreated, addDrawCallback);`
	`72`	`+ connect(ui->preview, &OBSQTDisplay::DisplayCreated, this, addDrawCallback);`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`OBSBasicInteraction::~OBSBasicInteraction()`