Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding group does not trigger child's "Hide Transition" #11446

Open
vladdeSV opened this issue Oct 24, 2024 · 9 comments
Open

Hiding group does not trigger child's "Hide Transition" #11446

vladdeSV opened this issue Oct 24, 2024 · 9 comments
Assignees
Labels
UI/UX Anything to do with changes or additions to UI/UX elements.

Comments

@vladdeSV
Copy link

Operating System Info

macOS 15

Other OS

No response

OBS Studio Version

30.2.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/JdlWWAeAGhHu4zkf

OBS Studio Crash Log URL

No response

Expected Behavior

When hiding or un-hiding a group, the group's children should apply their own transitions for hiding / unhiding.

Current Behavior

When hiding a group, the children do not apply their hiding transition. However, they do use their transitions when un-hiding.

Steps to Reproduce

  1. Create any element, eg. a Text
  2. Set the text's "Show Transition" and "Hide Transition" to Fade
  3. Verify transitions are working. Hide and un-hide the Text.
  4. Right-click the Text and click "Group Selected Items"
  5. Hide the group, and see that the Text disappears instantly
  6. Un-hide the group, and see that the Text uses the fade transition

Kapture 2024-10-24 at 21 20 02

Anything else we should know?

This is probably related to #8005, but it is different, as that issue seems to deal with only subscenes; this issue is about any element inside the group.

@derrod
Copy link
Member

derrod commented Oct 24, 2024

Working as expected. The group itself is being hidden, not the contained item(s), so their transitions aren't triggered. And it wouldn't make sense for that to be the case.

Edit: To elaborate why it doesn't make sense: The group could exist multiple times, or across multiple scenes, its items triggering the hide transition when the group is only hidden in one place wouldn't make sense.

@derrod derrod closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@vladdeSV
Copy link
Author

Sorry, just double checking: why does the "Show Transition" apply when showing the group? It is inconsistent.

Just to make sure I am clear enough: I changed both the Text's transitions to Swipe, and set the group's transitions to Fade – why does the Text use it's showing transition when showing the group?

Kapture 2024-10-24 at 21 31 21

When showing the group, you can see the group's fade transition apply at the same time as the Text's showing transition. But when hiding, only the group's Fade is applied, and not the Text's Swipe.

@vladdeSV
Copy link
Author

(Just saw the edit in the previous post)

[…] its items triggering the hide transition when the group is only hidden in one place wouldn't make sense.

Then why does the items' show transition trigger when showing the group?

@Fenrirthviti
Copy link
Member

Probably just an oversight with how groups function internally. Everything is working correct with how they are implemented, it's just sometimes not what users expect.

Even though I wouldn't consider this a bug, probably worth keeping open for tracking as it's inconsistent behavior that should be corrected.

@Fenrirthviti Fenrirthviti reopened this Oct 24, 2024
@Fenrirthviti Fenrirthviti added the UI/UX Anything to do with changes or additions to UI/UX elements. label Oct 24, 2024
@vladdeSV
Copy link
Author

vladdeSV commented Oct 24, 2024

Sorry for being pedantic, but these two statements confuse me:

Probably just an oversight
Everything is working correct

Is it correct behavior that child items' "Show Transition" triggers, but not the child items' "Hide Transition"?

@derrod
Copy link
Member

derrod commented Oct 24, 2024

Is it correct behavior that child items' "Show Transition" triggers, but not the child items' "Hide Transition"?

The behaviour that show transitions are showing is not correct either. Neither transition should be triggered by hiding/showing the group but there might be some weirdness with how the visibility tracking works there.

@vladdeSV
Copy link
Author

Thank you for clarifying 🙌


Personally (my opinion) I'd prefer if groups triggered both child show- and hide transitions. For instance, I am trying to create a group with the text "Ad break" and some graphics on my scene, which would have multiple items appear with different transitions.

@Fenrirthviti
Copy link
Member

To clarify my statement for posterity, I meant that it's working correct as implemented. This means it's not a bug, which is an important distinction when dealing with issue reports. Nothing is broken, it's working exactly as it's designed to work. There's just a situation or edge case that wasn't considered, leading to unexpected behavior from a user standpoint.

Groups have all sorts of issues like this, it's been kind of whack-a-mole with edge cases that weren't considered at the time of implementation.

@SuslikV
Copy link
Contributor

SuslikV commented Oct 26, 2024

Forum's voice from Windows users (to keep it linked):
https://obsproject.com/forum/threads/hide-transition-dont-work-when-you-disable-the-group.175159/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

No branches or pull requests

5 participants