-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readings based on selected text only #30
Comments
This repository is actually a fork of that one, and some of the vestiges of the "only apply to selected text" is found within the architecture for this plugin. Unfortunately, Anki changes have been pretty dramatic across the past 3 years since that plugin was seeing active development, and there've been numerous and frequent breaking changes. That will mean that we won't be able to directly lift the code from that repository/reenable it within this one, and it'll take additional research and development, especially as this plugin supports a wide range of Anki versions (meaning we need to ensure backwards compatibility and figure out how to do selection in each version). It can definitely be done, but this might rank lower on the overall priority list (or at least, on my personal one) as I can't imagine applying furigana to only a subset of an input box is an altogether frequent need. Not to mention it'll produce a more difficult UX for users to discover they can do this. To explore base assumptions though: what would you use case be for needing to apply furigana to only part of the text in the input box? Could that same need be solved with a different feature? |
Thank you for the detailed explanation on the background of this feature. To go back to the use case, my point is simply that displaying all furigana does not mimic an actual reading experience in Japanese (even in a learning context, e.g. a textbook or flashcards), where only readings for the most difficult words are shown. Displaying all furigana is distracting and can hinder your ability to progress as your brain may intuitively will go for the easiest route and hinge on furigana first. One alternative feature I can think of to elegantly solve this issue would be to add an option to hide furigana by default and display them only when hovering over (for mouse interfaces) or clicking (for touch interfaces) on a certain word. |
Hello, I should add some background since I'm mostly responsible for removing this feature. Unfortunately Anki removed a lot of the javascript binding "hacks" that we were using to be able to fetch the selected text. I tried my best to keep it by testing several techniques and ultimately decided to remove the feature during the refactoring since none of these techniques worked. I would love to bring it back if we manage to find a way to fetch the user selected text. This repo is indeed a fork of The original author of |
I think your feature request for hide furigana by default is easy to implement. Could you create a separate issue for that feature request so that we don't loose sight of it ? Can't give an ETA though, but I welcome contributions. |
Please consider adding the option to selectively generate readings based on current text selection, as opposed to the full field.
That option was available in another plugin (SimpleFurigana). The author went MIA but the plugin code is still available on Github under GPL 3.0 (see https://github.com/jcsirot/anki-simple-furigana).
Thank you!
The text was updated successfully, but these errors were encountered: