pkg(fix): use upstream or overlay as repository name (#10605) #10634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
reviewed
Jun 11, 2024
src/dune_rules/workspace.ml
Outdated
| let repos = default_repositories @ List.map ~f:Lazy.force repos in | ||
| let repos = | ||
| match List.map ~f:Lazy.force repos with | ||
| | [] -> default_repositories |
There was a problem hiding this comment.
if List.is_empty repos then default_repositories else List.map ~f:Lazy.force repos
moyodiallo
force-pushed
the
fix-upstream-name
branch
2 times, most recently
from
2ef17c4
to
e7df6ba
Compare
Signed-off-by: Alpha DIALLO <[email protected]>
moyodiallo
force-pushed
the
fix-upstream-name
branch
from
e7df6ba
to
ac1fa7c
Compare
rgrinberg
requested changes
Jun 13, 2024
My bad, this PR is not the good fix. And overriding won't be the good fix too, because we could have two different lock_dirs, one overrides the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10605