Skip to content

Commit 8404f96

Browse files
authored
Use open_in_bin not open_in for merlinpp (#1725)
from jonahbeckford/fix-file-open-win32
2 parents 05e90d8 + 1c43591 commit 8404f96

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ merlin NEXT_VERSION
99
- Add a query_num field to the `ocamlmerlin` responses to detect server crashes (#1716)
1010
+ editor modes
1111
- vim: load merlin under the ocamlinterface and ocamllex filetypes (#1340)
12+
- Fix merlinpp not using binary file open (#1725, fixes #1724)
1213

1314
merlin 4.13
1415
===========

src/ocaml/driver/pparse.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ let apply_pp ~workdir ~filename ~source ~pp =
177177
end else if not (Sys.file_exists fn_out) then
178178
Error (WrongMagic comm)
179179
else
180-
let ic = open_in fn_out in
180+
let ic = open_in_bin fn_out in
181181
let result = Misc.string_of_file ic in
182182
close_in ic;
183183
Ok result

0 commit comments

Comments
 (0)