-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Patch to fix async_ssl build #26886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to fix async_ssl build #26886
Conversation
I have merged the patches before checking this, sorry |
But the build of async_ssl is fine on the whole matrix, there are only a few ssl issues that are unrelated as far as I can see |
Following merging of ocaml/opam-source-archives#34
CI failures are:
AFAICT, this is good to merge. |
Should we make this a patch |
How so? I guess I can make a script that would break with this update, but I'm not sure there are standard tools around opam that would break. But yeah, we might as well fix it just in case. Question is: should we mark the unpatched package as not available because it's broken several plateforms? |
What I mean is if there are janestreet packages with version v0.17 requiring async_ssl with the (This all in the spirit of path to the least breakage/change, it will change once the new maintainership policy is in place) |
I see. Done, it's now a patch version (which makes sense because it's a patch I guess). |
Tests have already run, the lint and many tests have already passed |
Thanks |
DO NOT MERGE: wait until the CI succeeds, then merge ocaml/opam-source-archives#34, then change the URL for the patch, then merge