Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octez 21.0 packages #26890

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Octez 21.0 packages #26890

wants to merge 3 commits into from

Conversation

killian-delarue
Copy link
Contributor

Packages for Octez v21.0

@raphael-proust
Copy link
Contributor

Are the packages expected to run on windows? The windows CI fails but it seems to be network related or something. Idk. Still, should these packages have an available: clause with an os condition?

@raphael-proust
Copy link
Contributor

octez-rust-deps fails to build:

#=== ERROR while compiling octez-rust-deps.21.0 ===============================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | pinned(https://gitlab.com/tezos/tezos/-/archive/octez-v21.0/octez-source-21.0.tar.gz)
# path                 ~/.opam/4.14/.opam-switch/build/octez-rust-deps.21.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p octez-rust-deps -j 39
# exit-code            1
# env-file             ~/.opam/log/octez-rust-deps-7-ec9a10.env
# output-file          ~/.opam/log/octez-rust-deps-7-ec9a10.out
### output ###
# File "src/rust_deps/dune", lines 12-28, characters 0-515:
# 12 | (rule
# 13 |  (targets liboctez_rust_deps.a dlloctez_rust_deps.so wasmer.h wasm.h)
# 14 |  (deps
# ....
# 26 |   (file ../../src/lib_wasm_runtime/build.rs)
# 27 |   (glob_files_rec ../../src/lib_wasm_runtime/src/**.rs))
# 28 |  (action (no-infer (bash ./build.sh))))
# (cd _build/default/src/rust_deps && /usr/bin/bash -e -u -o pipefail -c ./build.sh)
# ./build.sh: line 20: cargo: command not found

Do you need to add a dependency to conf-rust or something like that?

["dune" "build" "-p" name "-j" jobs]
["dune" "runtest" "-p" name "-j" jobs] {with-test}
]
synopsis: "Fork of distributed. Use for Octez only"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't these internal libraries be moved as vendored dependency inside octez-lib? If they are internal-only there seems to be no reason to publish them

@killian-delarue
Copy link
Contributor Author

killian-delarue commented Nov 22, 2024

Are the packages expected to run on windows? The windows CI fails but it seems to be network related or something. Idk. Still, should these packages have an available: clause with an os condition?

Something like in e0f42b7 ?

@raphael-proust
Copy link
Contributor

Something like

Yes. Also you should probably add these constraints in the upstream project. That way it won't be an issue for the next release.

@killian-delarue
Copy link
Contributor Author

Something like

Yes. Also you should probably add these constraints in the upstream project. That way it won't be an issue for the next release.

It will 👍🏻 Thank you for the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants