-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octez 21.0 packages #26890
base: master
Are you sure you want to change the base?
Octez 21.0 packages #26890
Conversation
Are the packages expected to run on windows? The windows CI fails but it seems to be network related or something. Idk. Still, should these packages have an |
Do you need to add a dependency to |
["dune" "build" "-p" name "-j" jobs] | ||
["dune" "runtest" "-p" name "-j" jobs] {with-test} | ||
] | ||
synopsis: "Fork of distributed. Use for Octez only" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't these internal libraries be moved as vendored dependency inside octez-lib
? If they are internal-only there seems to be no reason to publish them
Something like in e0f42b7 ? |
eeb0754
to
e0f42b7
Compare
Yes. Also you should probably add these constraints in the upstream project. That way it won't be an issue for the next release. |
It will 👍🏻 Thank you for the suggestion |
Packages for Octez v21.0