Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] elpi (2.0.2) #26937

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

gares
Copy link
Contributor

@gares gares commented Nov 23, 2024

ELPI - Embeddable λProlog Interpreter

CHANGES:

Requires Menhir 20211230 and OCaml 4.13 or above.

  • Really fix tests on 32 bits systems

CHANGES:

Requires Menhir 20211230 and OCaml 4.13 or above.

- Really fix tests on 32 bits systems
@gares
Copy link
Contributor Author

gares commented Nov 24, 2024

I managed to solve the "thread create" issue that affected previous versions (it was a dune problem with a large stack).

I also managed to fix the test suite on 32 bit systems.

I have no clue what is wrong with the two failing jobs, but IMHO the package can be merged.

@gares
Copy link
Contributor Author

gares commented Nov 25, 2024

Btw, if you think the failures are important, I'm fine disabling the package on 32bit + 5.2, but I'm not sure I know opam's syntax well enough for doing so. Suggestions are welcome.

@shonfeder
Copy link
Contributor

Thanks for the updates, and for helping analyze the CI issues. These are test failures on those platforms, rather than build failures, so it is not as if the package cannot be installed or used there.

I think its fine to merge as is.

@shonfeder shonfeder merged commit ed26474 into ocaml:master Nov 26, 2024
2 of 3 checks passed
@gares gares deleted the release-elpi-v2.0.2 branch November 26, 2024 07:01
@gares
Copy link
Contributor Author

gares commented Nov 26, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants