cc @oconnor663

hmm, looks like the fix for windows 3.13 no longer works? PyO3/maturin-action#292 (comment)

regardless of 3.13 / 3.13t

does it work if you enable PyO3's generate-import-lib feature? 🤔

It looks to me like the lib path is missing for some reason, can you use PYO3_PRINT_CONFIG=1 env with just --interpreter 3.13? Might give us some hints...

@davidhewitt

  -- PYO3_PRINT_CONFIG=1 is set, printing configuration and halting compile --
  implementation=CPython
  version=3.13
  shared=true
  abi3=false
  lib_name=python313
  lib_dir=C:\hostedtoolcache\windows\Python\3.13.0\x64\libs
  executable=C:\hostedtoolcache\windows\Python\3.13.0\x64\python.exe
  pointer_width=64
  build_flags=
  suppress_build_script_link_lines=false

@davidhewitt looks like adding generate-import-lib worked! Can you explain what happened here?

Great! The generate-import-lib feature allows PyO3 to do exactly that - produce the library shim to link against instead of requiring one.

As to why the original library was not present, I'm not sure. I can try to debug that another time.

@ddelange thanks for being so on top of this stuff. At this point you're doing more to maintain the project than I am. I'm going to go ahead and make you a repo maintainer. If I ever go a few months without reviewing PRs again, I trust you to do what you think is best :)

@oconnor663 awesome, thanks for the trust and looking forward to collaborating!

now watching all activity!

P.S. soon you'll see a small PR incoming to bump gh-action-pypi-publish as soon as they release (also watching that one)

awaiting upstrean release: maturin is now included in their CI 🎉

pypa/gh-action-pypi-publish#313

hi @davidhewitt 👋

this error is back on main, despite generate-import-lib now being present. any ideas?

edit: fixed in #50