Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dismiss stale pull request approvals when new commits are pushed equivalent option #30

Open
yuichielectric opened this issue May 14, 2021 · 0 comments

Comments

@yuichielectric
Copy link
Contributor

GitHub's PR approval is given for a specific commit. Therefore, it can happen that the same person 'request change' once for the same PR and then 'approve' it. Therefore, I think there should be an option to determine whether the latest commit has been approved or not. The logic right now is that if a reviewer have approved once in the past, they're considered to have approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant