Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include target branch name at status checks name #351

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yuichielectric
Copy link
Contributor

A commit can be referred by multiple branches especially under the multiple stages approvals environment (e.g. dev -> test -> release) and there can be different approval requirements are needed for each stage.

In such a situation, we want to record whether each approval requirement was met for each target branch. That is why I include the target branch name to the status check name.

This PR fixes #350

@yuichielectric yuichielectric self-assigned this Sep 30, 2022
@yuichielectric
Copy link
Contributor Author

yuichielectric commented Sep 30, 2022

@mohan-the-octocat I just added the target branch name to the check status name. Could you test it before merging this PR?

You can try it out using octodemo/pr-gatekeeper@unique-status-name at your actions workflow.

Screen Shot 2022-09-30 at 18 08 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PR Gatekeeper status seems to be persisted across multiple concurrent PRs
1 participant