Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PR Gatekeeper status seems to be persisted across multiple concurrent PRs #350

Open
mohan-the-octocat opened this issue Sep 29, 2022 · 0 comments · May be fixed by #351
Open

The PR Gatekeeper status seems to be persisted across multiple concurrent PRs #350

mohan-the-octocat opened this issue Sep 29, 2022 · 0 comments · May be fixed by #351

Comments

@mohan-the-octocat
Copy link
Contributor

mohan-the-octocat commented Sep 29, 2022

What

PR Gatekeeper can accept different approve-config.yml files based on the source & target branch being merged. In multi-stage branching/ approval workflows, there may be multiple contexts where PR Gatekeeper is run.

But

When we have more than 1 Open Pull Request using PR Gatekeeper, the PR Gatekeeper Status reflects the status message from the more recently raised/ run PR.

And

This behaviour is confusing to the reviewers of the prior PRs, and the PR Gatekeeper Status needs to be unique per PR

So

Fixing this, will help us leverage PR gatekeeper's features in multi-stage approval workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant