Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winging It Live - OddContrast #648

Merged
merged 25 commits into from
Jul 5, 2024
Merged

Conversation

SondraE
Copy link
Contributor

@SondraE SondraE commented Jun 27, 2024

Related Issue(s)

647

Steps to test/reproduce

  • /2024/06/27/winging-it-live-03/
  • /blog/ _
  • /oddcontrast/

Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..winging-it-live-oddcontrast

@SondraE SondraE linked an issue Jun 27, 2024 that may be closed by this pull request
2 tasks
@SondraE
Copy link
Contributor Author

SondraE commented Jun 28, 2024

@mirisuzanne
I'm not sure why the winging episode I added isn't being displayed in the list of post or the list of winging it episodes.
Also I'd like to add the sponsor section at the bottom of this winging it episode post. How is that done?

* main: (47 commits)
  Avoid name collision and sponsor data on every page
  Address review
  review
  Work Item and Smashing Hour
  Fix Github sponsors, use env key
  Bump the npm-minor-upgrades group with 2 updates
  Automated webmentions update
  Add Github Sponsors
  Update content/workshops/cascading-layouts.md
  Move the workshop callout to the top of the post
  Tito registration for layouts april 2025
  Mentions from elsewhere
  Feature smashing workshop
  Remove workshop callouts in blog posts
  Update dates to ensure upcoming talks appear earlier.
  Update content/workshops/cascading-layouts.md
  No featured workshop, no registration, update events
  Adjust for upgraded RSS plugin
  Bump the npm-minor-upgrades group with 4 updates
  Automated webmentions update
  ...
@mirisuzanne
Copy link
Member

@SondraE

  • The file was missing a .md extension.
  • I added sponsors: true in the yaml data
  • I removed the Show Notes tag, since it's already added to all Winging It posts automatically

looks good to me!

@@ -0,0 +1,67 @@
---
title: Using New Color Formats
episode: 3
Copy link
Member

@jgerigmeyer jgerigmeyer Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this Episode 3? Should it be 7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the third episode of Winging It Live (as opposed to Winging It not live). @stacyk and I talked a bit about whether Winging It Live should replace Winging It and pick up the numbering where we left off, which would make this episode number 9. On the other hand, maybe the live Winging It is a different thing and therefore this is number 3. The Live episodes have a different design style and live in a different section of our YouTube channel, but if we're not planning anymore Winging It episodes that aren't live, then there's a good argument for this being episode 9. (We could also retroactively make the live episodes use the same design style as the non-live episodes.)

I'm open to what you all think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be winging it 9, as the method of recording shouldn't matter IMO. If we go on tour and do a live Live show, then we wouldn't start a new numbering.

Copy link
Member

@jgerigmeyer jgerigmeyer Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not looking at the YouTube channel, but I don't see any other episodes of Winging It Live on our site, nor a single mention of "Winging It Live" as a thing. So it's confusing for this to just say "on Winging It episode 3", right after another one that says "on Winging It episode 6". If we want Winging It Live to be its own thing, that should be reflected on our site as well.

content/blog/wingingit/winging-it-live-03.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-live-03.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-live-03.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-live-03.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-live-03.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-live-03.md Outdated Show resolved Hide resolved
@jgerigmeyer
Copy link
Member

Steps to test/reproduce

  • /2024/06/27/winging-it-live-03/
  • /blog/ (why isn't it showing up in the list?)
  • /oddcontrast/

@SondraE I don't see anything changing on the /oddcontrast/ page -- should there be something?

@SondraE
Copy link
Contributor Author

SondraE commented Jul 1, 2024

@stacyk @jgerigmeyer
Oops. I thought I had pushed my latest changes, but apparently I hadn't.
You will now see the correct header image, the video added to OddContrast tool page, and the episode number updated.

SondraE and others added 6 commits July 1, 2024 14:18
* main:
  Apply suggestions from code review
  Update example, summary
  adjust docs
  review-v2
  review
  Edits
  Update date and version
  Remove broken links to AEA
  Bump @11ty/eleventy from 3.0.0-alpha.13 to 3.0.0-alpha.14
  Bump the npm-minor-upgrades group with 3 updates
  Automated webmentions update
  Add Anchor position update
* main:
  Apply suggestions from code review
  Update example, summary
  adjust docs
  review-v2
  review
  Edits
  Update date and version
  Remove broken links to AEA
  Bump @11ty/eleventy from 3.0.0-alpha.13 to 3.0.0-alpha.14
  Bump the npm-minor-upgrades group with 3 updates
  Automated webmentions update
  Add Anchor position update
Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions but nothing that makes or breaks this.

content/blog/wingingit/winging-it-09.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-09.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-09.md Outdated Show resolved Hide resolved
content/blog/wingingit/winging-it-09.md Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the LIVE gradient addition :)

@jgerigmeyer jgerigmeyer merged commit 1015eb5 into main Jul 5, 2024
9 of 10 checks passed
@jgerigmeyer jgerigmeyer deleted the winging-it-live-oddcontrast branch July 5, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Winging It Live OddContrast to OddSite
5 participants