Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add real time search/filter #52

Open
stacyk opened this issue May 19, 2017 · 2 comments · May be fixed by #195
Open

Add real time search/filter #52

stacyk opened this issue May 19, 2017 · 2 comments · May be fixed by #195
Assignees
@mirisuzanne @stacyk @SondraE
Labels
enhancement WIP

Comments

@stacyk
Copy link
Member

stacyk commented May 19, 2017

In addition to the whole site search #28 it would be nice to have a filter like feature like on Lonely Planet's Style guide: http://rizzo.lonelyplanet.com/styleguide/design-elements/interface-icons
icon-filter

Would be useful for some components like icons and maybe colors.
@mirisuzanne mirisuzanne modified the milestone: Herman 1.0 May 19, 2017
@mirisuzanne mirisuzanne mentioned this issue May 19, 2017
Closed
@mirisuzanne mirisuzanne modified the milestones: Herman 1.0, Herman 1.x Stretch Goals May 19, 2017
wlonk added a commit that referenced this issue Nov 16, 2017
@wlonk
Add basic in-page filter
1e8b1a5 
Fixes #52.
@wlonk wlonk linked a pull request Nov 16, 2017 that will close this issue
Open
@jgerigmeyer
Copy link
Member

JS for reference: https://github.com/lonelyplanet/rizzo/blob/5ba4f99bd91ad2e3f8810ac6308915520d358cbe/app/assets/javascripts/lib/styleguide/svg.js

I think before this gets further we need a design proposal. Where all does the search show up (icons? colors? fonts? where else?), how should it work, etc.

@mirisuzanne
Copy link
Member

@stacyk I think we need to consider what exactly makes this feature better than built-in browser page-search. I'm not quite convinced yet that it solves a real problem. Maybe if it was an auto-complete dropdown of items?

@mirisuzanne mirisuzanne removed this from the Backlog milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirisuzanne mirisuzanne

@stacyk stacyk

@SondraE SondraE

Labels
enhancement WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[filter-in-page] Add basic in-page filter oddbird/sassdoc-theme-herman
4 participants
@mirisuzanne @jgerigmeyer @stacyk @SondraE