Reword stuff to satisfy spell-checker

Signed-off-by: Jim Klimov <[email protected]>

Author: jimklimov

.github/workflows/spelling/expect.txt

@@ -383,6 +383,7 @@ notest
 NOTMAKE
 nroff
 NSTIPS
+nsub
 nvpool
 nytprof
 OBJC
@@ -419,6 +420,7 @@ plaintar
 plist
 plugin
 png
+poolrootfs
 populat
 posix
 prebuilt
@@ -461,6 +463,7 @@ rmdir
 rmprog
 rmtmp
 ron
+rootds
 rootfs
 rootfs'es
 rpool

lib/ZnapZend/ZFS.pm

@@ -45,8 +45,8 @@ my $splitHostDataSet = sub {
     # If there are further bugs in the regex, comment away the
     # next implementation line and fall through to verbosely
     # debugging code below to try and iterate a fix.
-    # In the "if" clause below we separate the regexes for the
-    # use-case where we have two "@" characters:
+    # In the "if" clause below we separate the regular expressions
+    # for the use-case where we have two "@" characters:
     #   user@host:dataset@snap
     # from having zero or one "@" characters:
     #   host:dataset
@@ -57,6 +57,12 @@ my $splitHostDataSet = sub {
     # may have ":" chars of their own, e.g.
     #   ...@znapzend-auto-2024-01-08T10:22:13Z
     #   pond/export/vm-1:2
+    # Also note that we can not discern "X@Y:Z" strings by pattern
+    # alone - are they a remote "user@host:rootds" or a local
+    # "rootds@funny:snapname"? For practical purposes, we proclaim
+    # preference for the former: we are more likely to look at funny
+    # local snapshot names, than to back up to (or otherwise care
+    # about) remote pools' ROOT datasets.
     my $count = ($_[0] =~ tr/@//);
     if ($count > 1) {
         #return ($_[0] =~ /^(?:([^:\/]+):)?([^@\s]+|[^@\s]+\@[^@\s]+)$/);

t/znapzend-lib-splitter.t

@@ -4,7 +4,7 @@
 # since there are many use-cases and combinations to take care of.
 # We do so below by constructing "task" strings from components we
 # know to be a dataset name and some defined (or not) remote spec
-# and/or snapshot name, and deconstructing it back with the class
+# and/or snapshot name, and de-constructing it back with the class
 # method.
 #
 # Copyright (C) 2024 by Jim Klimov <[email protected]>
@@ -135,9 +135,9 @@ for my $r (qw(undef hostname username@hostname)) {
 
             # See big comment above:
             if ($task eq 'username@hostname:poolrootfs') {
-                isnt (defined ($remote), 1, "remote should BOGUSLY be not defined after parsing for this exceptional test case");
-                is (($dataSet eq "username"), 1, "dataSet has expected BOGUS value after parsing for this exceptional test case");
-                is (($snapshot eq "hostname:poolrootfs"), 1, "snapshot has expected BOGUS value after parsing for this exceptional test case");
+                isnt (defined ($remote), 1, "BOGUS exceptional test case: remote should be not defined after parsing for this exceptional test case");
+                is (($dataSet eq "username"), 1, "BOGUS exceptional test case: dataSet has expected BOGUS value after parsing for this exceptional test case");
+                is (($snapshot eq "hostname:poolrootfs"), 1, "BOGUS exceptional test case: snapshot has expected BOGUS value after parsing for this exceptional test case");
             } else {
                 is (($dataSet eq $d), 1, "dataSet has expected value after parsing");
 
@@ -181,22 +181,15 @@ for my $r (qw(undef hostname username@hostname)) {
         printTaskReportCFG($task, $remote, $dataSet);
 
         is (defined ($dataSet), 1, "dataSet should always be defined after parsing");
+        is (($dataSet eq $d), 1, "dataSet has expected value after parsing");
 
-        # See big comment above:
-#        if ($task eq 'username@hostname:poolrootfs') {
-#            isnt (defined ($remote), 1, "remote should BOGUSLY be not defined after parsing for this exceptional test case");
-#            is (($dataSet eq "username"), 1, "dataSet has expected BOGUS value after parsing for this exceptional test case");
-#        } else {
-            is (($dataSet eq $d), 1, "dataSet has expected value after parsing");
-
-            if ($r ne "undef") {
-                is (defined ($remote), 1, "remote should be defined after parsing this test case");
-                is (($remote eq $r), 1, "remote has expected value after parsing");
-            } else {
-                isnt (defined ($remote), 1, "remote should not be defined after parsing this test case");
-            }
+        if ($r ne "undef") {
+            is (defined ($remote), 1, "remote should be defined after parsing this test case");
+            is (($remote eq $r), 1, "remote has expected value after parsing");
+        } else {
+            isnt (defined ($remote), 1, "remote should not be defined after parsing this test case");
         }
-#    }
+    }
 }
 
 done_testing;