Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught javascript error and blank screen. #2168

Open
vdbergh opened this issue Jan 12, 2025 · 3 comments
Open

Uncaught javascript error and blank screen. #2168

vdbergh opened this issue Jan 12, 2025 · 3 comments

Comments

@vdbergh
Copy link
Contributor

vdbergh commented Jan 12, 2025

With this URL

https://tests.stockfishchess.org/tests/view/67843b58460e2910c51ddcc6?show_task=0

I get an uncaught javascript error and a blank screen

image

I don't know if it is reproducible for other people since it seems to have something to do with the github api.

@vdbergh
Copy link
Contributor Author

vdbergh commented Jan 13, 2025

It seems it was a temporary glitch since now it works.

@peregrineshahin
Copy link
Contributor

peregrineshahin commented Jan 25, 2025

Hint:

Promise.all([spsaPromise, diffPromise, tasksPromise])

This is the culprit line.
If any of the promises gets rejected then Promise.all does not enter the then, adding a catch would verify you that.
You might want to look at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled

@vdbergh
Copy link
Contributor Author

vdbergh commented Jan 26, 2025

Ok I see. Why don't you make a PR yourself? The code in that file has changed substantially since I last looked at it.

I wonder though if it would not be better to catch exceptions closer to where they appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants